[Bug 779966] New: Avoid usage of GstVideoGLTextureUploadMeta

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

Bug ID: 779966
Summary: Avoid usage of GstVideoGLTextureUploadMeta
Classification: Platform
Product: GStreamer
Version: git master
OS: Linux
Status: NEW
Severity: normal
Priority: Normal
Component: gstreamer-vaapi
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@gmail.com
QA Contact: gstreamer-***@lists.freedesktop.org
CC: ***@gmail.com, ***@igalia.com
Blocks: 779965
GNOME version: ---

The plan is for the upload meta to be replaced by gstreamer-gl and as such the
first steps to deprecating it are in place in bug 779965.

gstreamer-vaapi should avoid using it when deprecated symbols are disabled.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

Matthew Waters (ystreet00) <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #1 from Matthew Waters (ystreet00) <***@gmail.com> ---
Created attachment 347801
--> https://bugzilla.gnome.org/attachment.cgi?id=347801&action=edit
plugins: avoid using GstVideoGLTextureUploadMeta when GST_DISABLE_DEPRECATED is
defined

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

--- Comment #2 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Matthew, in which version did you create the patch? it doesn't apply in master
anymore, but looks way before branch 1.10

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

--- Comment #3 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 348022
--> https://bugzilla.gnome.org/attachment.cgi?id=348022&action=edit
plugins: deprecate usage GstVideoGLTextureUploadMeta

When GST_DISABLE_DEPRECATED is defined don't expose
GstVideoGLTextureUploadMeta

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

--- Comment #4 from Matthew Waters (ystreet00) <***@gmail.com> ---
It was based on master just after 1.10.0 was released :)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #347801|0 |1
is obsolete| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

Holger Kaelberer <***@getslash.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@getslash.de

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Priority|Normal |Low

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

Hyunjun Ko <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@igalia.com

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Whiteboard| |P3

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

Daniel van Vugt <***@canonical.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@canonical.c
| |om

--- Comment #5 from Daniel van Vugt <***@canonical.com> ---
AFAIK, the only efficient code path for clutter-gst (hence totem) is
GstVideoGLTextureUploadMeta. If you deprecate it then efficient video playback
in totem is lost, and clutter-gst will revert to the slow software upload path.

Do you plan on enhancing clutter-gst to give it some other efficient render
path in place of GstVideoGLTextureUploadMeta?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

Nicolas Dufresne (stormer) <***@ndufresne.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@ndufresne.ca

--- Comment #6 from Nicolas Dufresne (stormer) <***@ndufresne.ca> ---
To be fair, my push would be to deprecated cluttergst in favour of gtkglsink.
Pretty much all what we do in GL or zero-copy ends up incompatible due to
conflicting limitations (old cogl that is).

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

--- Comment #7 from Daniel van Vugt <***@canonical.com> ---
I totally agree, but Totem relies on clutter-gst and is the default video
player for Gnome. And Gnome is the default desktop for major Linuxes now.

Hence we're stuck with clutter-gst's performance being a priority for the major
Linux desktops.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

--- Comment #8 from Nicolas Dufresne (stormer) <***@ndufresne.ca> ---
(In reply to Daniel van Vugt from comment #7)

Post by "GStreamer" (GNOME Bugzilla)
I totally agree, but Totem relies on clutter-gst and is the default video
player for Gnome. And Gnome is the default desktop for major Linuxes now.
Hence we're stuck with clutter-gst's performance being a priority for the
major Linux desktops.

What is the difference between modifying Totem vs Modifying GStreamer ?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

--- Comment #9 from Daniel van Vugt <***@canonical.com> ---
I have no preference for what gets modified, so long as the outcome is the
same: Totem can still accept zero-copy video frames, somehow.

That could indeed be achieved by modifying Totem or GStreamer. See bug 740753
where I have a recent patch for the latter.

My previous comments really are just about ensuring there is no period of
uncertainty where Totem would have no efficient zero-copy code path. A feature
should not be deprecated until some replacement for it exists.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

--- Comment #10 from Matthew Waters (ystreet00) <***@gmail.com> ---
Created attachment 371742
--> https://bugzilla.gnome.org/attachment.cgi?id=371742&action=edit
vaapi: silence deprecation warnings from GstVideoGLTextureUploadMeta

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779966

GStreamer system administrator <***@gstreamer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |OBSOLETE

--- Comment #11 from GStreamer system administrator <***@gstreamer.net> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance:
https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/52.