[Bug 769436] New: vaapi: [RFC] remove memory:VASurface caps feature

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769436

Bug ID: 769436
Summary: vaapi: [RFC] remove memory:VASurface caps feature
Classification: Platform
Product: GStreamer
Version: git master
OS: Linux
Status: NEW
Severity: normal
Priority: Normal
Component: gstreamer-vaapi
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@igalia.com
QA Contact: gstreamer-***@lists.freedesktop.org
CC: ***@gmail.com, ***@igalia.com
GNOME version: ---

This is an idea: what if we get rid of the memory:VASurface caps feature?

The purpose of the caps feature is to restrict the type of caps the element can
process. But vaapi element can process as input two types of caps: system
memory and GstVaapiVideoMemory. As output, three: system memory, GL texture
upload and vaapi memory.

Do we need to annotate the vaapi memory?

I think we do not need it, since vaapi surfaces can be mapped onto images (not
completely, but almost).

Opinions?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769436

--- Comment #1 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 332565
--> https://bugzilla.gnome.org/attachment.cgi?id=332565&action=edit
remove memory:VASurface feature

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769436

Julien Isorce <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769436

Hyunjun Ko <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@igalia.com

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769436

Tim-Philipp Müller <***@zen.co.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@zen.co.uk
Severity|normal |enhancement

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769436

--- Comment #2 from Hyunjun Ko <***@igalia.com> ---

(In reply to Víctor Manuel Jáquez Leal from comment #0)

Post by "GStreamer" (GNOME Bugzilla)
Do we need to annotate the vaapi memory?
I think we do not need it, since vaapi surfaces can be mapped onto images
(not completely, but almost).

I agree with this.

IMHO, this change makes vaapi elements flexible during negotiation.
and makes source code for negotiation more simple.

Probably, this can fix #772457 and this kind of issues also.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769436

--- Comment #3 from sreerenj <***@gmail.com> ---
In theory, VASurface can be an encrypted (drm protected) too where there is no
download possible. How do we support this? may be just mark it as
non-mappable memory?
But keep in mind that we don't even know the pixel format of these type
buffers.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769436

Olivier Crête <***@ocrete.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@ocrete.ca

--- Comment #4 from Olivier Crête <***@ocrete.ca> ---
If it's not mappable and can only be used from other Vaapi elements, would it
make sense to make it a different caps, like video/x-vaapi-drm or somethign
like that?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769436

GStreamer system administrator <***@gstreamer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |OBSOLETE

--- Comment #5 from GStreamer system administrator <***@gstreamer.net> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance:
https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/42.