[Bug 796308] vaapi: gobjectify internal decoder class

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #12 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 372309
--> https://bugzilla.gnome.org/attachment.cgi?id=372309&action=edit
libs: decoder: vp9: implement reset() callback

remove destroy() and create() callback

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #7 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 372304
--> https://bugzilla.gnome.org/attachment.cgi?id=372304&action=edit
libs: decoder: jpeg: implement reset() callback

and remove create() and destroy() callbacks.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #9 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 372306
--> https://bugzilla.gnome.org/attachment.cgi?id=372306&action=edit
libs: decoder: mpeg4: implement reset() callback

remove destroy() and create() callback

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #13 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 372310
--> https://bugzilla.gnome.org/attachment.cgi?id=372310&action=edit
libs: decoder: remove destoy() and create() callbacks

They were all replaced by reset()

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #10 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 372307
--> https://bugzilla.gnome.org/attachment.cgi?id=372307&action=edit
libs: decoder: vc1: implement reset() callback

remove destroy() and create() callbacks

use g_clear_pointer for rbdu_buffer

no cast for enum

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #8 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 372305
--> https://bugzilla.gnome.org/attachment.cgi?id=372305&action=edit
libs: decoder: mpeg2: implement reset() callback

remove create() and destroy() callbacks

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #11 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 372308
--> https://bugzilla.gnome.org/attachment.cgi?id=372308&action=edit
libs: decoder: vp8: implement reset() callback

remove create() and destroy() callbacks

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #6 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 372302
--> https://bugzilla.gnome.org/attachment.cgi?id=372302&action=edit
libs: decoder: h265: implement reset() callback

and remove create() and destroy()
and use g_clear_pointer for dpb structure

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #2 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 372298
--> https://bugzilla.gnome.org/attachment.cgi?id=372298&action=edit
libs: decoder: remove gst_vaapi_decoder_new()

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #1 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 372297
--> https://bugzilla.gnome.org/attachment.cgi?id=372297&action=edit
libs: decoder: refactor decoders as gobject

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #5 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 372301
--> https://bugzilla.gnome.org/attachment.cgi?id=372301&action=edit
libs: decoder: h264: remove create() and destroy() callbacks

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #4 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 372300
--> https://bugzilla.gnome.org/attachment.cgi?id=372300&action=edit
libs: decoder: remove gst_vaapi_decoder_unref()

Replaced by gst_object_unref() in tests

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #3 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 372299
--> https://bugzilla.gnome.org/attachment.cgi?id=372299&action=edit
libs: decoder: remove gst_vaapi_decoder_ref()

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #14 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 372338
--> https://bugzilla.gnome.org/attachment.cgi?id=372338&action=edit
libs: filter: refactor filter as gobject

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #15 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 372339
--> https://bugzilla.gnome.org/attachment.cgi?id=372339&action=edit
libs: filters: remove custom ref() and unref()

Replacing them by gst_object_ref() and gst_object_unref()

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #16 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 372340
--> https://bugzilla.gnome.org/attachment.cgi?id=372340&action=edit
libs: filter: remove custom ref() and unref()

Replacing them by gst_object_ref() and gst_object_unref()

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|vaapi: gobjectify internal |vaapi: gobjectify internal
|decoder class |classes

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #17 from sreerenj <***@gmail.com> ---
Do you have any benchmarking results to share?; memory footprint when replacing
gstvaapiminiobject with gstobject?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #18 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
(In reply to sreerenj from comment #17)

Post by "GStreamer" (GNOME Bugzilla)
Do you have any benchmarking results to share?; memory footprint when
replacing gstvaapiminiobject with gstobject?

Nope. Though they would nice to have. I look for it.

Still, these patches changes only affects to the internal decoder and filter
(next will the encoders). Decoders and encoders only exists one per element
(1:1 mapping), in the case of the filter it may be used in other elements. And
I thing that GstObject offer more tooling (such as leak tracing).

Another story would be surfaces and buffers, where they might be replaces with
GstMiniObject, but that other story for now.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #19 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Ok... Finally I devoted some time to do a simple benchmark using valgrind's
massif tool.

The test program launches 4 videos to be rendered with a vaapisink in drm
(headless).

After initialization, with and without the patches, the memory consumption is
similar: ~17.5M in total.

Nonetheless, the peaks at initialization are significantly different:

WITHOUT these patches 47.14M
WITH these patches 44M

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #372338|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #20 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Attachment 372297 pushed as 0ca49a1 - libs: decoder: refactor decoders as
gobject
Attachment 372298 pushed as a75329c - libs: decoder: remove
gst_vaapi_decoder_new()
Attachment 372299 pushed as ad5eb75 - libs: decoder: remove
gst_vaapi_decoder_ref()
Attachment 372300 pushed as 4649ac1 - libs: decoder: remove
gst_vaapi_decoder_unref()
Attachment 372301 pushed as 7a9f7f0 - libs: decoder: h264: remove create() and
destroy() callbacks
Attachment 372302 pushed as 3dbddfa - libs: decoder: h265: implement reset()
callback
Attachment 372304 pushed as c1d65cf - libs: decoder: jpeg: implement reset()
callback
Attachment 372305 pushed as 0374a8c - libs: decoder: mpeg2: implement reset()
callback
Attachment 372306 pushed as 5b3f6eb - libs: decoder: mpeg4: implement reset()
callback
Attachment 372307 pushed as 2b207a4 - libs: decoder: vc1: implement reset()
callback
Attachment 372308 pushed as e493420 - libs: decoder: vp8: implement reset()
callback
Attachment 372309 pushed as 60dad9f - libs: decoder: vp9: implement reset()
callback
Attachment 372310 pushed as a2f923f - libs: decoder: remove destoy() and
create() callbacks
Attachment 372338 pushed as 99183e0 - libs: filter: refactor filter as gobject
Attachment 372340 pushed as ae46b1a - libs: filter: remove custom ref() and
unref()

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #372297|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #372299|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #372298|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #372301|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #372300|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #372302|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #372305|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #372304|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #372307|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #372308|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #372310|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #372306|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #372309|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #372340|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

--- Comment #21 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
GstVaapiWindow and all the encoders are still susceptible to be GObject
descendants. That's pending work so I don't close this bug yet.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

Nicolas Dufresne (ndufresne) <***@ndufresne.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@ndufresne.ca
Attachment #372339|0 |1
is obsolete| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796308

GStreamer system administrator <***@gstreamer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |OBSOLETE

--- Comment #22 from GStreamer system administrator <***@gstreamer.net> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance:
https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/96.