[Bug 785616] md5 is not always same under ubuntu UI mode.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

--- Comment #5 from Fei <***@intel.com> ---
I run the same cmd on SKL ubuntu 14.04(same commit id with my test on ubuntu
16.04), md5 look correct.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

--- Comment #3 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
(In reply to Fei from comment #2)

I used Ubuntu 16.04 LTS, and glib version is 2.48.2-0ubuntu1.
And I found when set vaapipostproc output format as nv12, the md5 always
same.
location=/media//yami_h264_Base_Ext_Main_profile/CABACI3_Sony_B.jsv '!'
h264parse '!' vaapih264dec '!' vaapipostproc format=nv12 '!' checksumsink2
frame-checksum=FALSE file-checksum=TRUE plane-checksum=FALSE
ec42e4b5ebde82b071e5dcea23763449

Strange, I got

for i in `seq 0 10`; do gst-launch-1.0 -q filesrc
location=~/patterns/bug785616.jsv ! h264parse ! vaapih264dec ! vaapipostproc
format=nv12 ! checksumsink2 frame-checksum=FALSE file-checksum=TRUE
plane-checksum=FALSE; done
eea6e740430ec3e9508e79ec3a054747
eea6e740430ec3e9508e79ec3a054747
eea6e740430ec3e9508e79ec3a054747
eea6e740430ec3e9508e79ec3a054747
eea6e740430ec3e9508e79ec3a054747
eea6e740430ec3e9508e79ec3a054747
eea6e740430ec3e9508e79ec3a054747
eea6e740430ec3e9508e79ec3a054747
eea6e740430ec3e9508e79ec3a054747
eea6e740430ec3e9508e79ec3a054747
eea6e740430ec3e9508e79ec3a054747

I'm in a SKL box too.

Linux miau 4.11.0-1-amd64 #1 SMP Debian 4.11.6-1 (2017-06-19) x86_64 GNU/Linux
libva commit id b65a3d9
intel-vaapi-driver commit id 51b5d37a
gstreamer-vaapi commit id 7d6a80e1

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

--- Comment #8 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
I just tested in wayland and got the same MD5
(095fc22b46f0822be4699dcc47d912c1)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

Hyunjun Ko <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@igalia.com

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

--- Comment #1 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
A bug in Ubuntu's glib??

I'm running this command in Debian testing, with
(libglib2.0-0:amd64 2.52.3-1 amd64 GLib library of C routines)

for i in `seq 0 10`; do gst-launch-1.0 -q filesrc
location=~/patterns/bug785616.jsv ! h264parse ! vaapih264dec ! vaapipostproc
format=i420 ! checksumsink2 frame-checksum=FALSE file-checksum=TRUE
plane-checksum=FALSE; done
095fc22b46f0822be4699dcc47d912c1
095fc22b46f0822be4699dcc47d912c1
095fc22b46f0822be4699dcc47d912c1
095fc22b46f0822be4699dcc47d912c1
095fc22b46f0822be4699dcc47d912c1
095fc22b46f0822be4699dcc47d912c1
095fc22b46f0822be4699dcc47d912c1
095fc22b46f0822be4699dcc47d912c1
095fc22b46f0822be4699dcc47d912c1
095fc22b46f0822be4699dcc47d912c1
095fc22b46f0822be4699dcc47d912c1

Which Ubuntu is? what glib version are you linking with? Can you try with
another distribution and compare with the md5 I get?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@coaxion.net

--- Comment #4 from Sebastian Dröge (slomo) <***@coaxion.net> ---
Might also be related to the hardware decoder?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

--- Comment #2 from Fei <***@intel.com> ---
I used Ubuntu 16.04 LTS, and glib version is 2.48.2-0ubuntu1.
And I found when set vaapipostproc output format as nv12, the md5 always same.
***@gst-skl:~/build# gst-launch-1.0 -q filesrc
location=/media//yami_h264_Base_Ext_Main_profile/CABACI3_Sony_B.jsv '!'
h264parse '!' vaapih264dec '!' vaapipostproc format=nv12 '!' checksumsink2
frame-checksum=FALSE file-checksum=TRUE plane-checksum=FALSE
ec42e4b5ebde82b071e5dcea23763449

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

--- Comment #6 from Fei <***@intel.com> ---
@Victor, did you configure gst-vaapi with enable egl? I disabled egl with
"--disable-egl" option, then md5 correct on Ubuntu 16.04.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

Julien Isorce <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

--- Comment #7 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
(In reply to Fei from comment #6)

Post by "GStreamer" (GNOME Bugzilla)
@Victor, did you configure gst-vaapi with enable egl? I disabled egl with
"--disable-egl" option, then md5 correct on Ubuntu 16.04.

I do. But I'm not using it. Are you working under Wayland?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

--- Comment #9 from Fei <***@intel.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #7)

Post by "GStreamer" (GNOME Bugzilla)
(In reply to Fei from comment #6)

Post by "GStreamer" (GNOME Bugzilla)
@Victor, did you configure gst-vaapi with enable egl? I disabled egl with
"--disable-egl" option, then md5 correct on Ubuntu 16.04.

I do. But I'm not using it. Are you working under Wayland?

No, I working under X mode.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

Fei <***@intel.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

--- Comment #10 from Fei <***@intel.com> ---
fixed with "apt-get install mesa-common-dev libgl1-mesa-dev libglu1-mesa-dev"
and rebuild gst-plugin-bad.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---

--- Comment #11 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
I'm reopening the issue. Finally I could reproduce it.

It happens when vaapipostproc uses GstVaapiDmaBufAllocator in its source pad
buffer pool.

Perhaps it is a bug in chekcsumsink2, or in the kernel, producing dmabuf-base
buffers slightly different than those mapped from VA surface.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|md5 is not always same |md5 output files, using
|under ubuntu UI mode. |dmabuf, are always
| |different

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

--- Comment #12 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
I had created a side-by-side diff of the frames checksum, (dmabuf map vs va
surface map) and there are some odd differences (attached)

Also, the output between runs using dmabuf randomly change.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

--- Comment #13 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 356842
--> https://bugzilla.gnome.org/attachment.cgi?id=356842&action=edit
dmabuf vs va surface

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

--- Comment #14 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 356843
--> https://bugzilla.gnome.org/attachment.cgi?id=356843&action=edit
dmabuf vs dmabuf

two different executions with dmabuf

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

--- Comment #15 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
this regression is because, vaapi plugins use dmabuf as much as possible, but
now some new problems, like this, are appearing.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

Nicolas Dufresne (stormer) <***@ndufresne.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@ndufresne.ca

--- Comment #16 from Nicolas Dufresne (stormer) <***@ndufresne.ca> ---
Do we end up de-tiling and re-tiling later when vaapi needs to look into the
ref frames ? Does the don't optimization has been merged ?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785616

GStreamer system administrator <***@gstreamer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |OBSOLETE

--- Comment #17 from GStreamer system administrator <***@gstreamer.net> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance:
https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/62.