[Bug 763494] New: h265parse: Segfault while tranforming hevc packetized stream to nal aligned bytestream

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763494

Bug ID: 763494
Summary: h265parse: Segfault while tranforming hevc packetized
stream to nal aligned bytestream
Classification: Platform
Product: GStreamer
Version: git master
OS: Linux
Status: NEW
Severity: critical
Priority: Normal
Component: gst-plugins-bad
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@gmail.com
QA Contact: gstreamer-***@lists.freedesktop.org
GNOME version: ---

Created attachment 323703
--> https://bugzilla.gnome.org/attachment.cgi?id=323703&action=edit
sample mkv stream

The following pipeline will segfault:

DISPLAY=:0 gst-launch-1.0 -v filesrc location= sample.mkv ! matroskademux !
h265parse ! "video/x-h265, stream-format=byte-stream, alignment=nal" !
vaapidecode ! vaapisink

Sample stream attached.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763494

--- Comment #1 from sreerenj <***@gmail.com> ---
Created attachment 323705
--> https://bugzilla.gnome.org/attachment.cgi?id=323705&action=edit
videoparsers: h265: Fix segfault whiile trasforming to nal aligned bytestream

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763494

--- Comment #2 from sreerenj <***@gmail.com> ---
It is high time for us to make a base_h264_h265_class !

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763494

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@coaxion.net
Attachment #323705|none |accepted-commit_now
status| |

--- Comment #3 from Sebastian Dröge (slomo) <***@coaxion.net> ---
Comment on attachment 323705
--> https://bugzilla.gnome.org/attachment.cgi?id=323705
videoparsers: h265: Fix segfault whiile trasforming to nal aligned bytestream

This code looks familiar ;) Thanks!

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763494

Luis de Bethencourt <***@debethencourt.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@debethencourt.com

--- Comment #4 from Luis de Bethencourt <***@debethencourt.com> ---
Sreerenj,
Thanks for the patch.

To whoever merges this,
I wouldn't nitpick if it wasn't in the subject line of the commit. Can you
change the "whiile" into "while"?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763494

--- Comment #5 from Luis de Bethencourt <***@debethencourt.com> ---
gsth264parse and gsth265parse look to be in sync.

Except for implementation design details that I can sync *after* the freeze.
For example gsth264parse moving a block of instructions to a function
_reset_stream_info(), or gsth264parse using GST_H265_PARSER_OK and gsth265parse
using GST_H265_PARSER_ERROR. function digit_to_string() and others defined at a
different place of the file.

Making the implementation design of both match will make future syncing through
diff a lot easier/faster. I will do this after the freeze.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763494

--- Comment #6 from sreerenj <***@gmail.com> ---
(In reply to Luis de Bethencourt from comment #4)

Post by "GStreamer" (GNOME Bugzilla)
Sreerenj,
Thanks for the patch.
To whoever merges this,
I wouldn't nitpick if it wasn't in the subject line of the commit. Can you
change the "whiile" into "while"?

Aha sorry, going to push it... :)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763494

sreerenj <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

--- Comment #7 from sreerenj <***@gmail.com> ---
commit 92f4eb45abbe5ada79d8752b58949f2a73af6d90
Author: Sreerenj Balachandran <***@intel.com>
Date: Fri Mar 11 17:34:03 2016 +0200

videoparsers: h265: Fix segfault while transforming hevc to nal aligned
bytestream

Create temporary ParseFrame and copy the nal size buffer region
for each nal unit like we did for h264.

https://bugzilla.gnome.org/show_bug.cgi?id=763494

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763494

sreerenj <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #323705|accepted-commit_now |committed
status| |

--- Comment #8 from sreerenj <***@gmail.com> ---
Review of attachment 323705:
--> (https://bugzilla.gnome.org/review?bug=763494&attachment=323705)

Pushed.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763494

Tim-Philipp Müller <***@zen.co.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@zen.co.uk
Target Milestone|git master |1.8.0

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763494

Tim-Philipp Müller <***@zen.co.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|1.8.0 |1.7.91

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763494

--- Comment #9 from Luis de Bethencourt <***@debethencourt.com> ---
Thanks Sreerenj! Great work :)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763494

Tim-Philipp Müller <***@zen.co.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|1.7.91 |1.6.4

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763494

Tim-Philipp Müller <***@zen.co.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
Whiteboard| |1.6.4