[Bug 781885] New: Do not rely on gl3ext.h being available when finding gl3.h

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781885

Bug ID: 781885
Summary: Do not rely on gl3ext.h being available when finding
gl3.h
Classification: Platform
Product: GStreamer
Version: git master
OS: Linux
Status: NEW
Severity: normal
Priority: Normal
Component: gst-plugins-bad
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@jensge.org
QA Contact: gstreamer-***@lists.freedesktop.org
GNOME version: ---

For GLES3 there is no gl3ext.h header as defined by Khronos[1]

Even though MESA is supplying an empty one, compiling gst-plugins-bad fails
against OpenGL drivers that are not mesa-based and adhere to the Khronos
definition to only ship gl2ext.h, even for GLES3

[1] https://www.khronos.org/registry/OpenGL/index_es.php#specs32

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781885

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@coaxion.net,
| |***@gmail.com

--- Comment #1 from Sebastian Dröge (slomo) <***@coaxion.net> ---
Can you propose a patch for this? And we probably still want to include a
gl3ext.h header if one exists.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781885

--- Comment #2 from Jens Georg <***@jensge.org> ---
Created attachment 351045
--> https://bugzilla.gnome.org/attachment.cgi?id=351045&action=edit
check for gl3ext.h existence

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781885

Matthew Waters (ystreet00) <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #351045|none |needs-work
status| |

--- Comment #3 from Matthew Waters (ystreet00) <***@gmail.com> ---
Review of attachment 351045:
--> (https://bugzilla.gnome.org/review?bug=781885&attachment=351045)

So, this could be made simpler by only checking/conditionalising for gl3ext.h
and moving the GLES2/gl2ext.h out of the else. I don't think we need to
conditionalize gl2ext.h for GLES3. It should always be there.

::: configure.ac
@@ +923,3 @@
+# endif
+# if $GLES3EXT2_H_DEFINE
+# include <GLES3/gl2ext.h>

GLES2/gl2ext.h

or just remove the one below outside the #if and remove this check

@@ +1396,3 @@
+# endif
+# if $GST_GL_HAVE_GLES3EXT2_H
+# include <GLES3/gl2ext.h>

ditto

::: gst-libs/gst/gl/gstglapi.h
@@ +46,3 @@
+# endif
+# if GST_GL_HAVE_GLES3EXT2_H
+# include <GLES3/gl2ext.h>

ditto

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781885

--- Comment #4 from Jens Georg <***@jensge.org> ---
(In reply to Matthew Waters (ystreet00) from comment #3)

Post by "GStreamer" (GNOME Bugzilla)
So, this could be made simpler by only checking/conditionalising for
gl3ext.h and moving the GLES2/gl2ext.h out of the else. I don't think we
need to conditionalize gl2ext.h for GLES3. It should always be there.

Yep, I misread and didn't see that it still references GLES2, not GLES3. Will
post an updated patch

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781885

Jens Georg <***@jensge.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #351045|needs-work |none
status| |
Attachment #351045|0 |1
is obsolete| |

--- Comment #5 from Jens Georg <***@jensge.org> ---
Created attachment 351167
--> https://bugzilla.gnome.org/attachment.cgi?id=351167&action=edit
v2 - check for gl3ext.h existence

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781885

Matthew Waters (ystreet00) <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #351167|none |needs-work
status| |

--- Comment #6 from Matthew Waters (ystreet00) <***@gmail.com> ---
Review of attachment 351167:
--> (https://bugzilla.gnome.org/review?bug=781885&attachment=351167)

Almost!

::: configure.ac
@@ +1383,3 @@
+# include <GLES3/gl3ext.h>
+# endif
+# include <GLES2/gl2ext.h>

missing a space for indentation.

::: gst-libs/gst/gl/gstglapi.h
@@ +45,3 @@
+# include <GLES3/gl3ext.h>
+# endif
+# include <GLES2/gl2ext.h>

ditto

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781885

--- Comment #7 from Jens Georg <***@jensge.org> ---
Created attachment 351609
--> https://bugzilla.gnome.org/attachment.cgi?id=351609&action=edit
v3 - check for gl3ext.h existence

I also have a patch for the meson part, but I cannot test that

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781885

Matthew Waters (ystreet00) <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #351167|0 |1
is obsolete| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781885

Matthew Waters (ystreet00) <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|git master |1.13.1

--- Comment #8 from Matthew Waters (ystreet00) <***@gmail.com> ---
Let's see what the buildbot's think of this.

commit 7b615e92b6be969af0ae10fb5cdf49e0f998cbda
Author: Matthew Waters <***@centricular.com>
Date: Thu May 11 20:05:24 2017 +1000

build/gl/meson: check for GLES3/gl3ext.h existence

791e7522ebcb75beb31fcace271dee1342d3505d for meson

https://bugzilla.gnome.org/show_bug.cgi?id=781885

commit 791e7522ebcb75beb31fcace271dee1342d3505d
Author: Jens Georg <***@jensge.org>
Date: Thu May 11 10:29:58 2017 +0200

build: Check for GLES3/gl3ext.h existence

Some OpenGL drivers do not ship this but use GLES2/gl2ext.h instead.
This is also in line with Khronos's recommendations

https://bugzilla.gnome.org/show_bug.cgi?id=781885

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781885

Matthew Waters (ystreet00) <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #351609|none |committed
status| |