[Bug 745460] New: media factory settings not properly applied down to sinks

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745460

Bug ID: 745460
Summary: media factory settings not properly applied down to
sinks
Classification: Platform
Product: GStreamer
Version: 1.4.5
OS: Linux
Status: NEW
Severity: minor
Priority: Normal
Component: gst-rtsp-server
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@parrot.com
QA Contact: gstreamer-***@lists.freedesktop.org
GNOME version: ---

Buffer size set at media factory level is not applied down to UDP sink.
This can be easily verified by running one of the sample tests:
* with GST_DEBUG="multiudpsink:7"
* modified to use gst_rtsp_media_factory_set_buffer_size()
* with suitable permissions.

Moreover, it is not possible to configure the DSCP/QoS field of UDP sinks
neither at the media factory level nor at the media level.

Althought it is possible for an application to set this using
gst_rtsp_stream_set_dscp_qos() at media-configure time, an additional handy
"gst_rtsp_media_factory_set_dscp_qos()" method would be more consistent with
the overall factory/media/stream API.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745460

--- Comment #1 from ***@parrot.com ---
Created attachment 298305
--> https://bugzilla.gnome.org/attachment.cgi?id=298305&action=edit
rtsp-media: propagate buffer size down to sinks

Apply media buffer size settings to related streams for RTP data only outgoing
sockets, i.e., not onto RTCP related sinks.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745460

***@parrot.com changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #298305|0 |1
is obsolete| |

--- Comment #2 from ***@parrot.com ---
Created attachment 298434
--> https://bugzilla.gnome.org/attachment.cgi?id=298434&action=edit
rtsp-media: propagate buffer size down to sinks

Apply media buffer size settings to related streams for RTP data only outgoing
sockets, i.e., not onto RTCP related sinks.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745460

--- Comment #3 from ***@parrot.com ---
Created attachment 298435
--> https://bugzilla.gnome.org/attachment.cgi?id=298435&action=edit
media-factory: complete DSCP QoS setting support

add dscp_qos setting support at factory and media level to setup IP DSCP field
of bounded UDP sinks.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745460

Tim-Philipp Müller <***@zen.co.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@zen.co.uk
Attachment #298434|none |reviewed
status| |
Attachment #298434|0 |1
is obsolete| |

--- Comment #4 from Tim-Philipp Müller <***@zen.co.uk> ---
Comment on attachment 298434
--> https://bugzilla.gnome.org/attachment.cgi?id=298434
rtsp-media: propagate buffer size down to sinks

Looks like this has been fixed independently with #749095, sorry.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745460

Tim-Philipp Müller <***@zen.co.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
Version|1.4.5 |git master
Summary|media factory settings not |media-factory: complete
|properly applied down to |DSCP QoS setting support
|sinks |

--- Comment #5 from Tim-Philipp Müller <***@zen.co.uk> ---
Retitling to reflect remaining issue/patch.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745460

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@coaxion.net
Attachment #298435|none |needs-work
status| |

--- Comment #6 from Sebastian Dröge (slomo) <***@coaxion.net> ---
Comment on attachment 298435
--> https://bugzilla.gnome.org/attachment.cgi?id=298435
media-factory: complete DSCP QoS setting support

Looks good but does not apply to latest GIT master. Please rebase :)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745460

--- Comment #7 from Sebastian Dröge (slomo) <***@coaxion.net> ---
Ping?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745460

***@parrot.com changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #298435|needs-work |none
status| |
Attachment #298435|0 |1
is obsolete| |

--- Comment #8 from ***@parrot.com ---
Created attachment 321372
--> https://bugzilla.gnome.org/attachment.cgi?id=321372&action=edit
media-factory: complete DSCP QoS setting support

add dscp_qos setting support at factory and media level to setup IP DSCP
field of bounded UDP sinks.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745460

--- Comment #9 from ***@parrot.com ---
Sorry for the late answer,

patch rebased but needs testing as I have no up to date gstreamer build at the
present time (unless you can afford waiting for next week...)

Regards

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745460

--- Comment #10 from Sebastian Dröge (slomo) <***@coaxion.net> ---
No need to hurry, let's wait until you tested it then :) Please let us know

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745460

--- Comment #11 from ***@parrot.com ---
(In reply to Sebastian Dröge (slomo) from comment #10)

Post by "GStreamer" (GNOME Bugzilla)
No need to hurry, let's wait until you tested it then :) Please let us know

Perfect. I come back to you next week ;)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745460

Tim-Philipp Müller <***@zen.co.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
Severity|minor |enhancement

--- Comment #12 from Tim-Philipp Müller <***@zen.co.uk> ---
Gregor, did you ever get around to testing this?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745460

GStreamer system administrator <***@gstreamer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution|--- |OBSOLETE

--- Comment #13 from GStreamer system administrator <***@gstreamer.net> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance:
https://gitlab.freedesktop.org/gstreamer/gst-rtsp-server/issues/6.