[Bug 793686] New: Unneeded BLIT operation when target is encoder (ex: vaapih264enc)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793686

Bug ID: 793686
Summary: Unneeded BLIT operation when target is encoder (ex:
vaapih264enc)
Classification: Platform
Product: GStreamer
Version: 1.12.x
OS: Linux
Status: NEW
Severity: normal
Priority: Normal
Component: gstreamer-vaapi
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@intel.com
QA Contact: gstreamer-***@lists.freedesktop.org
CC: ***@gmail.com, ***@igalia.com
GNOME version: ---

This operation
12.4/gstreamer-vaapi-1.12.4/gst-libs/gst/vaapi/gstvaapifilter.c:
pipeline_param->output_background_color = 0xff000000;
force BLIT usage (visible with Vtune or intel_gpu_top) - or this is only needed
when target is Display... useless when target is encoder (where Alpha is
ignored)

This cause extra HW resource usage that can be prevented as this operation is
not needed in encoder cases

Can we make this output_background_color configurable (or skip this operation
in encode pipeline) ?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793686

--- Comment #1 from sreerenj <***@gmail.com> ---
Yup, intel-vaapi-driver uses BLIT to clear the background color.

Maybe we can just use output_background_color "0" always to avoid unnecessary
HW usage.
Let's wait for other developers to comment...

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793686

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |enhancement

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793686

--- Comment #2 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
As it is hard to tell when the vaapipostproc is used for encoding upstream or
for anything else, I would remove it, but it is not clear to me what would
imply in not encoding use cases, such as EGL textures, where the GstVaapiFilter
is used.

And option would be to add a property to GstVaapiFilter to set the background
color, and set it to zero by default. Only set 0xff000000 when handling EGL
texture or the output color space is alfa (GST_VIDEO_INFO_HAS_ALPHA)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793686

GStreamer system administrator <***@gstreamer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |OBSOLETE

--- Comment #3 from GStreamer system administrator <***@gstreamer.net> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance:
https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/84.