[Bug 733395] New: Needs vmethods handle_request, handle_data to be able to override

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733395
GStreamer | gst-rtsp-server | 1.3.91

Summary: Needs vmethods handle_request, handle_data to be able
to override
Classification: Platform
Product: GStreamer
Version: 1.3.91
OS/Version: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: gst-rtsp-server
AssignedTo: gstreamer-***@lists.freedesktop.org
ReportedBy: ***@samsung.com
QAContact: gstreamer-***@lists.freedesktop.org
GNOME version: ---


Created an attachment (id=281175)
--> (https://bugzilla.gnome.org/attachment.cgi?id=281175)
RTSP msgs on miracast

I'm just starting to implement wifi display based on gst-rtsp-server.

There are some rtsp msgs based on wifi display spec, which means that i need to
implement new handling logic for these msgs.

Of course I can handle these msgs by creating new method. But I think
overriding handle_request in rtsp-client class would be better.

Please find the attached file, miracast rtsp msgs to be more easy to
understand.
And also attached patch.

Could you review this?

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733395
GStreamer | gst-rtsp-server | 1.3.91

--- Comment #1 from Hyunjun <***@samsung.com> 2014-07-19 12:08:37 UTC ---
Created an attachment (id=281176)
View: https://bugzilla.gnome.org/attachment.cgi?id=281176
Review: https://bugzilla.gnome.org/review?bug=733395&attachment=281176

Patch to add handle_request,handle_data vmethod

I add 2 vmethods, handle_request, handle_data.
For handle_response, I think I can handle by signal SIGNAL_HANDLE_RESPONSE.

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733395
GStreamer | gst-rtsp-server | 1.3.91

Tim-Philipp Müller <t.i.m> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@zen.co.uk
Severity|normal |enhancement

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733395
GStreamer | gst-rtsp-server | git

Tim-Philipp Müller <t.i.m> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Version|1.3.91 |git
Summary|Needs vmethods |rtsp-client: add
|handle_request, handle_data |overridable generic
|to be able to override |handle_request and
| |handle_data vmethods
Ever Confirmed|0 |1

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733395
GStreamer | gst-rtsp-server | git

--- Comment #2 from Hyunjun <***@samsung.com> 2014-11-24 13:47:54 UTC ---
Created an attachment (id=291362)
View: https://bugzilla.gnome.org/attachment.cgi?id=291362
Review: https://bugzilla.gnome.org/review?bug=733395&attachment=291362

Rebased

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733395
GStreamer | gst-rtsp-server | git

Hyunjun <zzoon.ko> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #291362|0 |1
is obsolete| |

--- Comment #3 from Hyunjun <***@samsung.com> 2014-11-24 15:56:46 UTC ---
Created an attachment (id=291376)
View: https://bugzilla.gnome.org/attachment.cgi?id=291376
Review: https://bugzilla.gnome.org/review?bug=733395&attachment=291376

Change commit msg, rebased

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733395
GStreamer | gst-rtsp-server | git

Reynaldo H. Verdejo Pinochet <reynaldo> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #281176|0 |1
is obsolete| |

--- Comment #4 from Reynaldo H. Verdejo Pinochet <***@opendot.cl> 2014-11-25 21:40:56 UTC ---
(From update of attachment 281176)
Please mark the previous patch obsolete with your
new iterations.

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733395
GStreamer | gst-rtsp-server | git

--- Comment #5 from Hyunjun <***@samsung.com> 2014-11-26 04:29:30 UTC ---
Ok
I'll keep in mind

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=733395

Tim-Philipp Müller <***@zen.co.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO

--- Comment #6 from Tim-Philipp Müller <***@zen.co.uk> ---
Is this still needed or can it be closed?

There quite a few of new signals and vfuncs added since.

I think you'd have to be a bit more specific and explain what exactly you can't
handle with the current API/mechanisms.

Note also that you can't just add vfuncs in the middle of a public class
structure, that breaks ABI compatibility, and you will also have to reduce the
padding when you add new stuff into the public structure, to keep the struct
size the same as before.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=733395

Tim-Philipp Müller <***@zen.co.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #291376|none |needs-work
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=733395

GStreamer system administrator <***@gstreamer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution|--- |OBSOLETE

--- Comment #7 from GStreamer system administrator <***@gstreamer.net> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance:
https://gitlab.freedesktop.org/gstreamer/gst-rtsp-server/issues/3.