[Bug 785706] vaapipostproc: upstream caps negotiation fails

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785706

--- Comment #1 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
The problem is upstream caps negotiation is not fully implemented in
vaapipostproc.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785706

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|vaapipostproc caps |vaapipostproc: upstream
|negotiation |caps negotiation fails

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785706

--- Comment #2 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
I've tested these pipelines on current master and 1.12 replacing appsrc with
videotestsrc


(In reply to Tomas Rataj from comment #0)

gst-launch-1.0 appsrc is-live=true
caps="video/x-raw,format=BGRx,width=1280,height=1024,framerate=20/1" !
videorate ! vaapipostproc ! video/x-raw,format=NV12,framerate=10/1 ! fakesink

This still fails. In my understanding it fails because videorate sets an
already fixated caps by setting itself as passthrough.

gst-launch-1.0 appsrc is-live=true
caps="video/x-raw,format=BGRx,width=1280,height=1024,framerate=20/1" !
videorate ! video/x-raw,framerate=10/1 ! vaapipostproc !
video/x-raw,format=NV12 ! fakesink

But this one is working as expected.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785706

Hyunjun Ko <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@igalia.com

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785706

--- Comment #3 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 360596
--> https://bugzilla.gnome.org/attachment.cgi?id=360596&action=edit
vaapipostproc: use scoped variable for return value

Instead of reusing a parameter variable for the return value of
gst_vaapipostproc_fixate_caps(), this patch uses the function scoped
pointer. Thus, the code is cleaner.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785706

--- Comment #4 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 360597
--> https://bugzilla.gnome.org/attachment.cgi?id=360597&action=edit
vaapipostproc: removed unused parameter

Removed caps parameter from gst_vaapipostproc_transform_caps_impl()
helper function since the it is not used.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785706

--- Comment #5 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 360598
--> https://bugzilla.gnome.org/attachment.cgi?id=360598&action=edit
vaapipostproc: use scoped variable for return value

Instead of reusing a parameter variable for the return value of
gst_vaapipostproc_transform_caps(), this patch uses the function
scoped pointer. Thus, the code is cleaner.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785706

--- Comment #6 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
These patches do not fix the problem. They are just a clean up of the code.

But I haven't found a way to fix this issue since vaapipostproc, when doing
deinterlacing, it modifies the src caps framerate, thus I cannot figure out a
way to set the sink caps framerate given the vaapipostproc src caps, since the
media also has to be considere.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785706

--- Comment #7 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Attachment 360596 pushed as bedaa13 - vaapipostproc: use scoped variable for
return value
Attachment 360597 pushed as d3732a7 - vaapipostproc: removed unused parameter
Attachment 360598 pushed as bedaa13 - vaapipostproc: use scoped variable for
return value

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785706

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #360596|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785706

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #360597|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785706

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #360598|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785706

GStreamer system administrator <***@gstreamer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |OBSOLETE

--- Comment #8 from GStreamer system administrator <***@gstreamer.net> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance:
https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/64.