[Bug 789596] New: gstreamer build fails if .git isn't in the expected place

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789596

Bug ID: 789596
Summary: gstreamer build fails if .git isn't in the expected
place
Classification: Platform
Product: GStreamer
Version: git master
OS: Linux
Status: NEW
Severity: normal
Priority: Normal
Component: don't know
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@gmail.com
QA Contact: gstreamer-***@lists.freedesktop.org
GNOME version: ---

Because of:

https://cgit.freedesktop.org/gstreamer/gstreamer/tree/autogen.sh#n37

If the .git directory is not at the top of the repository then this will fail.

There are multiple reasons why this might be the case: the repository might be
a submodule of some other, or the working dir may have been checked out to a
different place.

This also affects the meson build system, see:

https://cgit.freedesktop.org/gstreamer/gstreamer/tree/meson.build#n454

And it also affects all gstreamer plugin repositories which use the common
submodule.


The actual location of the .git directory can be found with:

git rev-parse --git-dir

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789596

--- Comment #1 from Alistair Buxton <***@gmail.com> ---
--absolute-git-dir would be better as it predictably gives you an absolute
path, but it needs a newer version of git.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789596

Tim-Philipp Müller <***@zen.co.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
CC| |***@zen.co.uk

--- Comment #2 from Tim-Philipp Müller <***@zen.co.uk> ---
Please feel free to propose a patch.

Does the failure just affect the commit hooks?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789596

--- Comment #3 from Tim-Philipp Müller <***@zen.co.uk> ---
Created attachment 367095
--> https://bugzilla.gnome.org/attachment.cgi?id=367095&action=edit
autogen.sh.in: fix pre-commit hook install if autogen lives in a subdir (for
common submodule)

Could you check if this works right for you in autogen.sh (The patch won't be
useful to you since it only modifies the template file for autogen.sh):

# Install GNU indent-based pre-commit hook for doing clean commits that
# maintain the GStreamer coding style.
#
# Don't assume this autogen.sh or the common module is at the top-level
# of the git checkout, it might be a unified git repo with the gstreamer
# code living in a subdirectory within the git repository.
if git --version 2>/dev/null >/dev/null; then
gitdir=`git rev-parse --git-dir`
curprefix=`git rev-parse --show-prefix` # will have trailing slash
if test ! \( -x "$gitdir/hooks/pre-commit" -a -L "$gitdir/hooks/pre-commit"
\);
then
rm -f "$gitdir/hooks/pre-commit"
if ! ln -s "../../$curprefix""common/hooks/pre-commit.hook"
"$gitdir/hooks/pre-commit" 2> /dev/null
then
echo "Failed to create commit hook symlink, copying instead ..."
cp "../../$curprefix""common/hooks/pre-commit.hook"
"$gitdir/hooks/pre-commit"
fi
fi
fi

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789596

--- Comment #4 from Alistair Buxton <***@gmail.com> ---
Yes, works for me. The error is gone and gstreamer builds correctly. I didn't
test with the plugin repos.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789596

GStreamer system administrator <***@gstreamer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution|--- |OBSOLETE

--- Comment #5 from GStreamer system administrator <***@gstreamer.net> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance:
https://gitlab.freedesktop.org/gstreamer/gstreamer-project/issues/12.