[Bug 791876] New: vaapipostproc bt709 support

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791876

Bug ID: 791876
Summary: vaapipostproc bt709 support
Classification: Platform
Product: GStreamer
Version: git master
OS: Linux
Status: NEW
Severity: normal
Priority: Normal
Component: gstreamer-vaapi
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@ubicast.eu
QA Contact: gstreamer-***@lists.freedesktop.org
CC: ***@gmail.com, ***@igalia.com
GNOME version: ---

I am decoding with vaapidecodebin (autoplugged through decodebin), which scales
automagically. However i need bt709 support to avoid an additional conversion
between bt601 and bt709, or the following will crash:

$ gst-launch-1.0 videotestsrc num-buffers=1 ! x264enc ! h264parse !
vaapidecodebin ! "video/x-raw, format=(string)NV12, width=(int)960,
height=(int)540, framerate=(fraction)30, colorimetry=(string)bt709,
pixel-aspect-ratio=1/1" ! fakesink

Works:

$ gst-launch-1.0 videotestsrc num-buffers=1 ! x264enc ! h264parse !
vaapidecodebin ! videoconvert ! "video/x-raw, format=(string)NV12,
width=(int)960, height=(int)540, framerate=(fraction)30,
colorimetry=(string)bt709, pixel-aspect-ratio=1/1" ! fakesink

Is it possible to support bt709 ?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791876

--- Comment #1 from Florent Thiéry <***@ubicast.eu> ---
Actually, vaapipostproc will define bt709 if the resolution is 1080p, but bt601
below (which fits the specifications).

Basically what is missing is the possibility to override the choice made
internally by vaapipostproc. I'm editing the ticket title to reflect this.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791876

Florent Thiéry <***@ubicast.eu> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|vaapipostproc bt709 support |vaapipostproc not allowing
| |overriding colorimetry
| |(bt601/709) by downstream
| |caps

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791876

--- Comment #2 from Florent Thiéry <***@ubicast.eu> ---
My use case is about compositing video from NV12 as a 1080p canvas with
compositor; i am feeding compositor with video from vaapidecodebin, and scaling
is handled by vaapipostproc.

Feeding multiple 1080p inputs into a single 1080p canvas results in sub-1080p
resolutions, which results in vaapipostproc fixating colorimetry to bt601, but
the downstream compositor will work in bt709 since the final output is 1080p.

What i'm trying to avoid is to let compositor handle all the colorimetry
conversion work (which is software only and single-threaded).

This fails:
gst-build]$ gst-launch-1.0 videotestsrc num-buffers=1 ! "video/x-raw,
width=(int)320, height=(int)240, framerate=(fraction)30/1, format=(string)I420"
! x264enc ! vaapidecodebin ! "video/x-raw, format=(string)NV12,
width=(int)960, height=(int)540, framerate=(fraction)30,
colorimetry=(string)bt709, pixel-aspect-ratio=1/1" ! fakesink

This works:
gst-build]$ gst-launch-1.0 videotestsrc num-buffers=1 ! "video/x-raw,
width=(int)320, height=(int)240, framerate=(fraction)30/1, format=(string)I420"
! x264enc ! vaapidecodebin ! "video/x-raw, format=(string)NV12,
width=(int)960, height=(int)540, framerate=(fraction)30,
colorimetry=(string)bt601, pixel-aspect-ratio=1/1" ! fakesink

Inversely, this works:
gst-launch-1.0 videotestsrc num-buffers=1 ! "video/x-raw, width=(int)320,
height=(int)240, framerate=(fraction)30/1, format=(string)I420" ! x264enc !
vaapidecodebin ! "video/x-raw, format=(string)NV12, width=(int)1920,
height=(int)1080, framerate=(fraction)30, colorimetry=(string)bt709,
pixel-aspect-ratio=1/1" ! fakesink -v

This fails:
gst-launch-1.0 videotestsrc num-buffers=1 ! "video/x-raw, width=(int)320,
height=(int)240, framerate=(fraction)30/1, format=(string)I420" ! x264enc !
vaapidecodebin ! "video/x-raw, format=(string)NV12, width=(int)1920,
height=(int)1080, framerate=(fraction)30, colorimetry=(string)bt601,
pixel-aspect-ratio=1/1" ! fakesink

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791876

GStreamer system administrator <***@gstreamer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |OBSOLETE

--- Comment #3 from GStreamer system administrator <***@gstreamer.net> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance:
https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/80.