[Bug 750111] New: rtsp-media: emit signal for preparing dynamic payloads

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750111

Bug ID: 750111
Summary: rtsp-media: emit signal for preparing dynamic payloads
Classification: Platform
Product: GStreamer
Version: git master
OS: Linux
Status: NEW
Severity: enhancement
Priority: Normal
Component: gst-rtsp-server
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@collabora.com
QA Contact: gstreamer-***@lists.freedesktop.org
GNOME version: ---

Created attachment 304268
--> https://bugzilla.gnome.org/attachment.cgi?id=304268&action=edit
patch

When using dynamic payloads, it is useful to know when rtsp-media has connected
to the pad-added signal, so that the application code can continue to add those
pads. If the dynpay element is a decodebin, the pads are always added after the
element changes state to PAUSED, which is set after connecting the pad-added
signal internally and therefore it works fine. However, there can be other
cases where the application needs to add the pads externally and therefore it
needs to know when is the right moment to do so.

This patch adds a "preparing" signal that is emitted at the end of
start_prepare, and compliments the "prepared" and "unprepared" signals.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750111

--- Comment #1 from George Kiagiadakis <***@collabora.com> ---
Any thoughts on this?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750111

Xavier Claessens <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Blocks| |767021

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750111

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #304268|none |needs-work
status| |

--- Comment #2 from Sebastian Dröge (slomo) <***@coaxion.net> ---
Review of attachment 304268:
--> (https://bugzilla.gnome.org/review?bug=750111&attachment=304268)

::: gst/rtsp-server/rtsp-media.h
@@ +158,3 @@
void (*removed_stream) (GstRTSPMedia *media, GstRTSPStream *
stream);

+ void (*preparing) (GstRTSPMedia *media);

This breaks ABI, has to go at the very end and remove some padding

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750111

George Kiagiadakis <***@tolabaki.gr> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #304268|needs-work |none
status| |
Attachment #304268|0 |1
is obsolete| |

--- Comment #3 from George Kiagiadakis <***@tolabaki.gr> ---
Created attachment 346559
--> https://bugzilla.gnome.org/attachment.cgi?id=346559&action=edit
rtsp-media: emit signal for preparing dynamic payloads

Here is a fixed (wrt ABI issues) version of the patch, which applies on top of
latest master.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750111

GStreamer system administrator <***@gstreamer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |OBSOLETE

--- Comment #4 from GStreamer system administrator <***@gstreamer.net> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance:
https://gitlab.freedesktop.org/gstreamer/gst-rtsp-server/issues/11.