[Bug 793886] New: vaapisink: White is rendered pink with AMD card, hue wrong all along

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793886

Bug ID: 793886
Summary: vaapisink: White is rendered pink with AMD card, hue
wrong all along
Classification: Platform
Product: GStreamer
Version: git master
OS: Linux
Status: NEW
Severity: normal
Priority: Normal
Component: gstreamer-vaapi
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@igalia.com
QA Contact: gstreamer-***@lists.freedesktop.org
CC: ***@gmail.com, ***@igalia.com
GNOME version: ---

Testcase:

$ gst-launch-1.0 multifilesrc location="frame_01.png"
caps="image/png,framerate=\(fraction\)3/1" ! pngdec ! videoconvert ! vaapisink

Works fine with xvimagesink:

$ gst-launch-1.0 multifilesrc location="frame_01.png"
caps="image/png,framerate=\(fraction\)3/1" ! pngdec ! videoconvert !
xvimagesink

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793886

--- Comment #1 from Alicia Boya García <***@igalia.com> ---
Created attachment 369037
--> https://bugzilla.gnome.org/attachment.cgi?id=369037&action=edit
frame_01.png (test vector)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793886

--- Comment #2 from Alicia Boya García <***@igalia.com> ---
Created attachment 369038
--> https://bugzilla.gnome.org/attachment.cgi?id=369038&action=edit
frame_01.png (wrong output)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793886

--- Comment #3 from Alicia Boya García <***@igalia.com> ---
Created attachment 369039
--> https://bugzilla.gnome.org/attachment.cgi?id=369039&action=edit
Color_Wheel.png (test vector)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793886

--- Comment #4 from Alicia Boya García <***@igalia.com> ---
Created attachment 369040
--> https://bugzilla.gnome.org/attachment.cgi?id=369040&action=edit
Color_Wheel.png (wrong output)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793886

--- Comment #5 from Alicia Boya García <***@igalia.com> ---
Created attachment 369041
--> https://bugzilla.gnome.org/attachment.cgi?id=369041&action=edit
river.png (test vector)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793886

--- Comment #6 from Alicia Boya García <***@igalia.com> ---
Created attachment 369042
--> https://bugzilla.gnome.org/attachment.cgi?id=369042&action=edit
river.png (wrong output)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793886

--- Comment #7 from Alicia Boya García <***@igalia.com> ---
This problem does not reproduce when the image is encoded to h264.

$ gst-launch-1.0 multifilesrc location="frame_01.png"
caps="image/png,framerate=\(fraction\)3/1" ! pngdec ! videoconvert ! x264enc !
vaapih264dec ! vaapisink

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793886

Alicia Boya García <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|vaapisink: White is |vaapisink: White is
|rendered pink with AMD |rendered pink with AMD
|card, hue wrong all along |card, wrong hue everywhere

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793886

--- Comment #8 from Alicia Boya García <***@igalia.com> ---
Turns out the problem is RGBA and BGRA pixel formats being misread.

This can be reproduced even more easily with a capsfilter:

These two reproduce the problem:

gst-launch-1.0 -v videotestsrc ! video/x-raw, format=RGBA ! vaapisink
gst-launch-1.0 -v videotestsrc ! video/x-raw, format=BGRA ! vaapisink

For comparison, YUV based formats like these work without problems:

gst-launch-1.0 -v videotestsrc ! video/x-raw, format=I420 ! vaapisink
gst-launch-1.0 -v videotestsrc ! video/x-raw, format=NV12 ! vaapisink

(In the pipeline of the previous message, vaapih264dec decoded the h264 frames
to NV12, therefore the problem did not reproduce.)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793886

Alicia Boya García <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|vaapisink: White is |vaapisink: White is
|rendered pink with AMD |rendered pink with AMD
|card, wrong hue everywhere |card, wrong hue everywhere
| |in RGBA and BGRA formats

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793886

Julien Isorce <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793886

GStreamer system administrator <***@gstreamer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |OBSOLETE

--- Comment #9 from GStreamer system administrator <***@gstreamer.net> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance:
https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/85.