Discussion:
[Bug 761761] New: splitmuxsink: Caps changes not handled
Add Reply
"GStreamer" (GNOME Bugzilla)
2016-02-09 12:18:44 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Bug ID: 761761
Summary: splitmuxsink: Caps changes not handled
Classification: Platform
Product: GStreamer
Version: 1.7.1
OS: Windows
Status: NEW
Severity: normal
Priority: Normal
Component: gst-plugins-good
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@hotmail.com
QA Contact: gstreamer-***@lists.freedesktop.org
GNOME version: ---

When changing caps the splitmuxsink closes the file being written to and stops
processing frames.

pipeline:
appsrc -> videoscale -> capsfilter-> videorate -> videoconverter -> x264enc ->
splitmuxsink

The mux in the splitmuxsink is an avimux.
The sink in the splitmuxsink is a filesink.

Incoming frames have variable frame dimensions.

If I replace the splitmuxsink with the avimux and filesink then the pipeline
successfully adapts to changing frame dimensions.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2016-02-11 14:50:13 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Thiago Sousa Santos <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #1 from Thiago Sousa Santos <***@gmail.com> ---
Could you provide a sample application or an unit test to reproduce this issue?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2016-02-16 15:23:35 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
CC| |***@coaxion.net
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-15 20:15:45 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Olivier Crête <***@ocrete.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@ocrete.ca
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-15 20:15:53 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

--- Comment #3 from Olivier Crête <***@ocrete.ca> ---
Created attachment 345872
--> https://bugzilla.gnome.org/attachment.cgi?id=345872&action=edit
splitmuxsink: Remove unused ready_for_output
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-15 20:15:49 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

--- Comment #2 from Olivier Crête <***@ocrete.ca> ---
Created attachment 345871
--> https://bugzilla.gnome.org/attachment.cgi?id=345871&action=edit
splitmuxsink: Change files on incompatible caps
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-15 20:15:58 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

--- Comment #4 from Olivier Crête <***@ocrete.ca> ---
Created attachment 345873
--> https://bugzilla.gnome.org/attachment.cgi?id=345873&action=edit
splitmuxsink: Remove always TRUE if()
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-15 20:16:06 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

--- Comment #6 from Olivier Crête <***@ocrete.ca> ---
Created attachment 345875
--> https://bugzilla.gnome.org/attachment.cgi?id=345875&action=edit
splitmuxsink: Remove unused next_max_out_running_time
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-15 20:16:02 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

--- Comment #5 from Olivier Crête <***@ocrete.ca> ---
Created attachment 345874
--> https://bugzilla.gnome.org/attachment.cgi?id=345874&action=edit
splitmuxsink: Remove unused muxed_out_time
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-15 20:19:57 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Olivier Crête <***@ocrete.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345872|none |rejected
status| |
Attachment #345872|0 |1
is obsolete| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-15 20:20:06 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Olivier Crête <***@ocrete.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345873|none |rejected
status| |
Attachment #345873|0 |1
is obsolete| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-15 20:36:11 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

--- Comment #7 from Olivier Crête <***@ocrete.ca> ---
The first patch in the series fixes this bug by cutting a new file when the
caps change and the muxer rejects that change. I'm totally unsure if I'm doing
it correctly. My test case includes a RTP stream which a variable frame size.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-15 20:36:27 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Olivier Crête <***@ocrete.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-15 21:35:57 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

--- Comment #8 from Olivier Crête <***@ocrete.ca> ---
Created attachment 345884
--> https://bugzilla.gnome.org/attachment.cgi?id=345884&action=edit
splitmuxsink: Reset ready_for_output on state change

I'm not sure if this is enough, but it was strange that it was never reset.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-16 02:52:00 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Jan Schmidt <***@noraisin.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345874|none |accepted-commit_now
status| |

--- Comment #9 from Jan Schmidt <***@noraisin.net> ---
Review of attachment 345874:
--> (https://bugzilla.gnome.org/review?bug=761761&attachment=345874)

muxed_out_time isn't needed any more since I rewrote how fragments are
scheduled for output / switching.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-16 02:52:56 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Jan Schmidt <***@noraisin.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345875|none |accepted-commit_now
status| |

--- Comment #10 from Jan Schmidt <***@noraisin.net> ---
Review of attachment 345875:
--> (https://bugzilla.gnome.org/review?bug=761761&attachment=345875)

cool
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-16 02:54:54 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Jan Schmidt <***@noraisin.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345884|none |accepted-commit_now
status| |

--- Comment #11 from Jan Schmidt <***@noraisin.net> ---
Review of attachment 345884:
--> (https://bugzilla.gnome.org/review?bug=761761&attachment=345884)

Yes, thanks!
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-16 03:07:47 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Jan Schmidt <***@noraisin.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345871|none |needs-work
status| |

--- Comment #12 from Jan Schmidt <***@noraisin.net> ---
Review of attachment 345871:
--> (https://bugzilla.gnome.org/review?bug=761761&attachment=345871)

I'm not sure this will work entirely correctly. I think it will attempt to open
a new fragment without having collected the first buffer of the new fragment,
which is needed for the format-location-full signal.

We probably need some extra logic to end the old file, but defer opening the
new one by setting ready_for_output to FALSE until the next video buffer
arrives.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-17 00:32:32 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Olivier Crête <***@ocrete.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345871|needs-work |none
status| |
Attachment #345871|0 |1
is obsolete| |

--- Comment #13 from Olivier Crête <***@ocrete.ca> ---
Created attachment 346028
--> https://bugzilla.gnome.org/attachment.cgi?id=346028&action=edit
splitmuxsink: Change files on incompatible caps

Here is an updated version that instead just sends the EOS
directly and drops all event until a buffer arrives so that
we have the buffer for the signal.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-17 00:42:50 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Olivier Crête <***@ocrete.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #346028|0 |1
is obsolete| |

--- Comment #14 from Olivier Crête <***@ocrete.ca> ---
Created attachment 346029
--> https://bugzilla.gnome.org/attachment.cgi?id=346029&action=edit
splitmuxsink: Change files on incompatible caps
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-17 00:44:54 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Olivier Crête <***@ocrete.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #346029|0 |1
is obsolete| |

--- Comment #15 from Olivier Crête <***@ocrete.ca> ---
Created attachment 346030
--> https://bugzilla.gnome.org/attachment.cgi?id=346030&action=edit
splitmuxsink: Change files on incompatible caps

Updated again to reset the ready_for_output.. And also only drop sticky events
as I think we want to let flushes through.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-17 09:55:51 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Jan Schmidt <***@noraisin.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #346030|none |accepted-commit_now
status| |

--- Comment #16 from Jan Schmidt <***@noraisin.net> ---
Review of attachment 346030:
--> (https://bugzilla.gnome.org/review?bug=761761&attachment=346030)

Looks OK to me now :)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-17 20:11:26 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Olivier Crête <***@ocrete.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

--- Comment #17 from Olivier Crête <***@ocrete.ca> ---
Merged:

commit d8868c633900a77139ea263b4bfe26970991d8a0
Author: Olivier Crête <***@collabora.com>
Date: Wed Feb 15 14:48:58 2017 -0500

splitmuxsink: Change files on incompatible caps

https://bugzilla.gnome.org/show_bug.cgi?id=761761

commit f79a7afac2413687705ba9ddb999b4914404c68b
Author: Olivier Crête <***@collabora.com>
Date: Wed Feb 15 16:35:01 2017 -0500

splitmuxsink: Reset ready_for_output on state change

https://bugzilla.gnome.org/show_bug.cgi?id=761761

commit 5059b9b8c99608cfd3321f96170e0c135457c041
Author: Olivier Crête <***@collabora.com>
Date: Wed Feb 15 15:09:06 2017 -0500

splitmuxsink: Remove unused next_max_out_running_time

https://bugzilla.gnome.org/show_bug.cgi?id=761761

commit c98d932fb869ab6e763972360b435830147a4414
Author: Olivier Crête <***@collabora.com>
Date: Wed Feb 15 15:07:32 2017 -0500

splitmuxsink: Remove unused muxed_out_time

https://bugzilla.gnome.org/show_bug.cgi?id=761761
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-17 20:11:48 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Olivier Crête <***@ocrete.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|git master |1.11.2
OS|Windows |All
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-17 20:12:02 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Olivier Crête <***@ocrete.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345874|accepted-commit_now |committed
status| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-17 20:12:07 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Olivier Crête <***@ocrete.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345875|accepted-commit_now |committed
status| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-17 20:12:12 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Olivier Crête <***@ocrete.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345884|accepted-commit_now |committed
status| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-17 20:12:17 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=761761

Olivier Crête <***@ocrete.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #346030|accepted-commit_now |committed
status| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
Loading...