[Bug 784005] New: tests: Fixes for souphttpsrc SSL test

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784005

Bug ID: 784005
Summary: tests: Fixes for souphttpsrc SSL test
Classification: Platform
Product: GStreamer
Version: 1.12.1
OS: All
Status: NEW
Severity: normal
Priority: Normal
Component: gst-plugins-good
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@gmail.com
QA Contact: gstreamer-***@lists.freedesktop.org
GNOME version: ---

(patches incoming)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784005

--- Comment #1 from Jan Alexander Steffens (heftig) <***@gmail.com> ---
Created attachment 354106
--> https://bugzilla.gnome.org/attachment.cgi?id=354106&action=edit
[PATCH 1/4] tests: souphttpsrc: Update test-cert.pem

Recent GnuTLS disregards the Common Name and only looks at the Subject
Alternative Name extension. Since our test-cert has no SAN extension,
validation fails.

Generate a new certificate with SAN. In addition to 127.0.0.1, for good
measure make it valid for localhost and ::1, too.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784005

--- Comment #2 from Jan Alexander Steffens (heftig) <***@gmail.com> ---
Created attachment 354107
--> https://bugzilla.gnome.org/attachment.cgi?id=354107&action=edit
tests: souphttpsrc: Make ssl_cert/key_file static

Just a bit of cleanup.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784005

--- Comment #3 from Jan Alexander Steffens (heftig) <***@gmail.com> ---
Created attachment 354108
--> https://bugzilla.gnome.org/attachment.cgi?id=354108&action=edit
[PATCH 3/4] tests: souphttpsrc: Avoid deprecated server ssl properties

The ssl-cert-file and ssl-key-file properties are deprecated. Use the
soup_server_set_ssl_cert_file function to load the files.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784005

--- Comment #4 from Jan Alexander Steffens (heftig) <***@gmail.com> ---
Created attachment 354109
--> https://bugzilla.gnome.org/attachment.cgi?id=354109&action=edit
[PATCH 4/4] tests: souphttpsrc: Avoid deprecated ssl-ca-file property

SoupSession's ssl-ca-file property is deprecated. Use the recommended
tls-database property.

This is a bit more complex as it requires creating a GTlsFileDatabase
object for an absolute (!) path to the CA certificates file.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784005

--- Comment #5 from Jan Alexander Steffens (heftig) <***@gmail.com> ---
(In reply to Jan Alexander Steffens (heftig) from comment #1)

It's also possible that the SAN stuff is a red herring and GnuTLS doesn't like
SHA1, since the new cert uses SHA256.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784005

Nicolas Dufresne (stormer) <***@ndufresne.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #354107|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784005

Nicolas Dufresne (stormer) <***@ndufresne.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #354109|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784005

Nicolas Dufresne (stormer) <***@ndufresne.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #354106|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784005

Nicolas Dufresne (stormer) <***@ndufresne.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #354108|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784005

Nicolas Dufresne (stormer) <***@ndufresne.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |***@ndufresne.ca
Resolution|--- |FIXED

--- Comment #6 from Nicolas Dufresne (stormer) <***@ndufresne.ca> ---
Thanks. All patches looked good and they also fixes the souphttpsrc failing
test.

e63a12c77d6ff74b6d0c410ec2453bd9688ca065 tests: souphttpsrc: Update
test-cert.pem
27a0ea8cf54f580f2babb03ddadccb7ea7616f56 tests: souphttpsrc: Make
ssl_cert/key_file static
9922091f1b50bf6c48ffb25be4e3bccabcee209c tests: souphttpsrc: Avoid
deprecated server ssl properties
aa8ac28d86a5c45314a6d62cfd579842f8aecad2 tests: souphttpsrc: Avoid
deprecated ssl-ca-file property

Attachment 354107 pushed as 27a0ea8 - tests: souphttpsrc: Make
ssl_cert/key_file static

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784005

Nicolas Dufresne (stormer) <***@ndufresne.ca> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|git master |1.13.1

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784005

--- Comment #7 from Jan Alexander Steffens (heftig) <***@gmail.com> ---
Can you also add this patchset to 1.12?