[Bug 767546] New: gstrtpj2k: support j2c and jp2 formats

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

Bug ID: 767546
Summary: gstrtpj2k: support j2c and jp2 formats
Classification: Platform
Product: GStreamer
Version: git master
OS: Linux
Status: NEW
Severity: normal
Priority: Normal
Component: gst-plugins-good
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@gmail.com
QA Contact: gstreamer-***@lists.freedesktop.org
GNOME version: ---

Currently, only jpc is supported.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@coaxion.net
Summary|gstrtpj2k: support j2c and |rtpj2k: support j2c and jp2
|jp2 formats |formats
Severity|normal |enhancement

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

--- Comment #1 from Sebastian Dröge (slomo) <***@coaxion.net> ---
Alternatively, conversion could be implemented in jpeg2000parse (like the
stream-format conversion for h264/h265/aac/etc)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

--- Comment #2 from ***@gmail.com <***@gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #1)

Post by "GStreamer" (GNOME Bugzilla)
Alternatively, conversion could be implemented in jpeg2000parse (like the
stream-format conversion for h264/h265/aac/etc)

I actually like that approach better than re-implementing jp2 parsing in both
places.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Component|gst-plugins-good |gst-plugins-bad
Summary|rtpj2k: support j2c and jp2 |jpeg2000parse: Add support
|formats |for conversion between
| |J2C/JP2/JPC

--- Comment #3 from Sebastian Dröge (slomo) <***@coaxion.net> ---
Let's do that then :)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

--- Comment #4 from Aaron Boxer <***@gmail.com> ---
Created attachment 353581
--> https://bugzilla.gnome.org/attachment.cgi?id=353581&action=edit
initial support for JP2 format

We treat JP2 as JPC, with extraneous bytes at the beginning.
So, JP2 gets translated into JPC.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

--- Comment #5 from Aaron Boxer <***@gmail.com> ---
This is a simple change, but it does allow us to parse JP2 files. So, could be
merged. Still need to add code to parse JP2 header, in future.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

--- Comment #6 from Aaron Boxer <***@gmail.com> ---
a shout out to repo mergers :) this very simple patch allows parser to handle
JP2 images. Tested and working correctly in my work flow.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #353581|none |needs-work
status| |

--- Comment #7 from Sebastian Dröge (slomo) <***@coaxion.net> ---
Review of attachment 353581:
--> (https://bugzilla.gnome.org/review?bug=767546&attachment=353581)

Makes sense but does not apply to latest GIT master unfortunately

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

--- Comment #8 from Aaron Boxer <***@gmail.com> ---
Thanks for the review - will wait for the other two patches to be merged before
fix this one up :)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

--- Comment #9 from Sebastian Dröge (slomo) <***@coaxion.net> ---
The others are merged now :)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

Aaron Boxer <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #353581|needs-work |none
status| |
Attachment #353581|0 |1
is obsolete| |

--- Comment #10 from Aaron Boxer <***@gmail.com> ---
Created attachment 355251
--> https://bugzilla.gnome.org/attachment.cgi?id=355251&action=edit
initial support for JP2 format

rebase with master

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

--- Comment #11 from Aaron Boxer <***@gmail.com> ---
Thank. Should apply now :)

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #355251|none |needs-work
status| |

--- Comment #12 from Sebastian Dröge (slomo) <***@coaxion.net> ---
Review of attachment 355251:
--> (https://bugzilla.gnome.org/review?bug=767546&attachment=355251)

::: gst/videoparsers/gstjpeg2000parse.c
@@ +109,3 @@
GST_STATIC_PAD_TEMPLATE ("sink", GST_PAD_SINK,
GST_PAD_ALWAYS,
+ GST_STATIC_CAPS ("image/x-jpc;image/x-j2c"));

You should probably add JP2 to the caps here and handle those caps?

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

--- Comment #13 from Aaron Boxer <***@gmail.com> ---
Sample pipeline:

gst-launch-1.0 -v filesrc location=some.jp2 ! typefind ! openjpegdec !
imagefreeze ! autovideosink

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

Aaron Boxer <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #355251|needs-work |none
status| |
Attachment #355251|0 |1
is obsolete| |

--- Comment #14 from Aaron Boxer <***@gmail.com> ---
Created attachment 355323
--> https://bugzilla.gnome.org/attachment.cgi?id=355323&action=edit
initial support for JP2 format

added jp2 to sink caps. Parser now treats jp2 as j2c format.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

--- Comment #15 from Sebastian Dröge (slomo) <***@coaxion.net> ---
Next step: actually parsing the JP2 header and making use of that information
for the caps :)

commit e10276a6164578b7e19e5b15f56e403876e45a3b (HEAD -> master)
Author: Aaron Boxer <***@gmail.com>
Date: Sat Jun 24 11:18:06 2017 -0400

jpeg2000parse: initial support for JP2 format

This is a simple way of supporting JP2 : we treat is as JPC, and throw
away header info.

https://bugzilla.gnome.org/show_bug.cgi?id=767546

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #355323|none |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|git master |1.13.1

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767546

--- Comment #16 from Aaron Boxer <***@gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #15)

Post by "GStreamer" (GNOME Bugzilla)
Next step: actually parsing the JP2 header and making use of that information
for the caps :)

Yes!