Discussion:
[Bug 778379] New: gstplayer: Add gst_player_get_state API
(too old to reply)
"GStreamer" (GNOME Bugzilla)
2017-02-09 08:33:24 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778379

Bug ID: 778379
Summary: gstplayer: Add gst_player_get_state API
Classification: Platform
Product: GStreamer
Version: 1.x
OS: Linux
Status: NEW
Severity: enhancement
Priority: Normal
Component: gst-plugins-bad
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@nxp.com
QA Contact: gstreamer-***@lists.freedesktop.org
GNOME version: ---

For gstpalyer state, currently we can only get the state by state_change
callback, when mainloop start running.

However, if we need to get the current state when mainloop has not started
running. There is no way to get the gstplayer state.

So considering add this gst_player_get_state() API to get the current player
state.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-09 08:36:59 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778379

--- Comment #1 from Lyon <***@nxp.com> ---
Created attachment 345291
--> https://bugzilla.gnome.org/attachment.cgi?id=345291&action=edit
patch for add gst_player_get_state() API
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-09 11:28:35 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778379

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345291|none |needs-work
status| |

--- Comment #2 from Sebastian Dröge (slomo) <***@coaxion.net> ---
Review of attachment 345291:
--> (https://bugzilla.gnome.org/review?bug=778379&attachment=345291)

Generally looks good

::: gst-libs/gst/player/gstplayer.c
@@ +4363,3 @@
+ *
+ * Gets current GstPlayer state.
+ *

This needs some further documentation though. It's not guaranteed that the
state returned is the current state, it might've changed in the meantime
already. Can you add something about that?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-09 12:02:33 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778379

Lyon <***@nxp.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345291|needs-work |none
status| |
Attachment #345291|0 |1
is obsolete| |

--- Comment #3 from Lyon <***@nxp.com> ---
Created attachment 345304
--> https://bugzilla.gnome.org/attachment.cgi?id=345304&action=edit
Update patch for add get_state API

Update the function description
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-15 09:33:09 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778379

--- Comment #4 from Lyon <***@nxp.com> ---
Hi slomo:
Could you please help review the new patch? Could it be accepted?
Thanks
Lyon
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
Loading...