Discussion:
[Bug 778703] New: timecodestamper: Timecode from current system time
(too old to reply)
"GStreamer" (GNOME Bugzilla)
2017-02-15 18:04:06 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Bug ID: 778703
Summary: timecodestamper: Timecode from current system time
Classification: Platform
Product: GStreamer
Version: git master
OS: Linux
Status: NEW
Severity: normal
Priority: Normal
Component: gst-plugins-bad
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@toolsonair.com
QA Contact: gstreamer-***@lists.freedesktop.org
GNOME version: ---

Created attachment 345863
--> https://bugzilla.gnome.org/attachment.cgi?id=345863&action=edit
timecodestamper: Timecode from current system time

Add an new property to start from a given timecode
instead of zero. Also, add a new flag which automatically
sets this first timecode to the current system time in
local time zone.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-15 18:07:39 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@coaxion.net
Severity|normal |enhancement
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-15 18:08:56 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345863|none |accepted-commit_now
status| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-15 18:09:49 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Depends on| |778702
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-16 15:44:39 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Georg Lippitsch <***@toolsonair.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345863|accepted-commit_now |none
status| |
Attachment #345863|0 |1
is obsolete| |

--- Comment #1 from Georg Lippitsch <***@toolsonair.com> ---
Created attachment 345953
--> https://bugzilla.gnome.org/attachment.cgi?id=345953&action=edit
timecodestamper: Timecode from current system time
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-16 17:34:49 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Georg Lippitsch <***@toolsonair.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345953|0 |1
is obsolete| |

--- Comment #2 from Georg Lippitsch <***@toolsonair.com> ---
Created attachment 345976
--> https://bugzilla.gnome.org/attachment.cgi?id=345976&action=edit
timecodestamper: Timecode from current system time
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-16 17:39:57 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Vivia Nikolaidou <***@ahiru.eu> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345953|none |needs-work
status| |

--- Comment #3 from Vivia Nikolaidou <***@ahiru.eu> ---
Review of attachment 345953:
--> (https://bugzilla.gnome.org/review?bug=778703&attachment=345953)

::: gst/timecode/gsttimecodestamper.c
@@ +142,3 @@
+ g_param_spec_boxed ("first-timecode",
+ "Timecode at the first frame",
+ "If unset, the timecode will start at 0",

You should write a description (and check that it works) about which property
overrides which. For instance, it would make sense for one of FIRST_TIMECODE
and FIRST_NOW to override the other, and for both to override CLOCK_SOURCE.
Maybe you should add a "mode" option that would point to one of {running-time,
from-clock, from-date-time, now}, but that would require the user to set two
properties. Which solution do you think looks cleaner?

@@ +477,3 @@
}
+ } else if (timecodestamper->source_clock == NULL &&
+ timecodestamper->first_tc == NULL) {

Add some sanity checks (especially in this function) that the timecodestamper
won't act up in case e.g. both source-clock and first-timecode are given.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-16 17:40:00 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

--- Comment #4 from Vivia Nikolaidou <***@ahiru.eu> ---
Review of attachment 345953:
--> (https://bugzilla.gnome.org/review?bug=778703&attachment=345953)

::: gst/timecode/gsttimecodestamper.c
@@ +142,3 @@
+ g_param_spec_boxed ("first-timecode",
+ "Timecode at the first frame",
+ "If unset, the timecode will start at 0",

You should write a description (and check that it works) about which property
overrides which. For instance, it would make sense for one of FIRST_TIMECODE
and FIRST_NOW to override the other, and for both to override CLOCK_SOURCE.
Maybe you should add a "mode" option that would point to one of {running-time,
from-clock, from-date-time, now}, but that would require the user to set two
properties. Which solution do you think looks cleaner?

@@ +477,3 @@
}
+ } else if (timecodestamper->source_clock == NULL &&
+ timecodestamper->first_tc == NULL) {

Add some sanity checks (especially in this function) that the timecodestamper
won't act up in case e.g. both source-clock and first-timecode are given.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-21 14:06:30 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Georg Lippitsch <***@toolsonair.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345976|0 |1
is obsolete| |

--- Comment #5 from Georg Lippitsch <***@toolsonair.com> ---
Created attachment 346357
--> https://bugzilla.gnome.org/attachment.cgi?id=346357&action=edit
timecodestamper: Timecode from current system time
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-22 13:21:26 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Vivia Nikolaidou <***@ahiru.eu> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #346357|none |reviewed
status| |

--- Comment #6 from Vivia Nikolaidou <***@ahiru.eu> ---
Review of attachment 346357:
--> (https://bugzilla.gnome.org/review?bug=778703&attachment=346357)

Looks good to me, thanks!
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-22 18:52:45 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #346357|reviewed |needs-work
status| |

--- Comment #7 from Sebastian Dröge (slomo) <***@coaxion.net> ---
Review of attachment 346357:
--> (https://bugzilla.gnome.org/review?bug=778703&attachment=346357)

Looks good but please split this into 3 patches. These are 3 separate changes,
even your commit message reads like that :)

::: gst/timecode/gsttimecodestamper.c
@@ +304,3 @@
+ timecodestamper->current_tc->minutes = timecodestamper->first_tc->minutes;
+ timecodestamper->current_tc->seconds = timecodestamper->first_tc->seconds;
+ timecodestamper->current_tc->frames = timecodestamper->first_tc->frames;

Should maybe be documented that only these fields are taken (what about field
count btw?) and not flags, framerate, etc.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-22 21:34:12 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Georg Lippitsch <***@toolsonair.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #346357|needs-work |none
status| |
Attachment #346357|0 |1
is obsolete| |

--- Comment #8 from Georg Lippitsch <***@toolsonair.com> ---
Created attachment 346514
--> https://bugzilla.gnome.org/attachment.cgi?id=346514&action=edit
timecodestamper: First timecode property
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-22 21:34:40 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

--- Comment #9 from Georg Lippitsch <***@toolsonair.com> ---
Created attachment 346515
--> https://bugzilla.gnome.org/attachment.cgi?id=346515&action=edit
timecodestamper: First timecode from current system time
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-22 21:35:08 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

--- Comment #10 from Georg Lippitsch <***@toolsonair.com> ---
Created attachment 346516
--> https://bugzilla.gnome.org/attachment.cgi?id=346516&action=edit
timecodestamper: Remove clock-source property
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-23 17:52:36 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703
Bug 778703 depends on bug 778702, which changed state.

Bug 778702 Summary: videotimecode: Init from GDateTime
https://bugzilla.gnome.org/show_bug.cgi?id=778702

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-23 18:01:05 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

--- Comment #11 from Sebastian Dröge (slomo) <***@coaxion.net> ---
Attachment 346514 pushed as 290f3ca - timecodestamper: First timecode property
Attachment 346515 pushed as 2cc6264 - timecodestamper: First timecode from
current system time
Attachment 346516 pushed as fc2ca69 - timecodestamper: Remove clock-source
property
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-23 18:01:09 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #346514|none |committed
status| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-23 18:01:13 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #346515|none |committed
status| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-23 18:01:17 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #346516|none |committed
status| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-23 18:01:32 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|git master |1.11.2
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-04-13 11:57:48 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

Tim-Philipp Müller <***@zen.co.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@zen.co.uk

--- Comment #12 from Tim-Philipp Müller <***@zen.co.uk> ---
I wonder if "first-time-from-systemtime" or such would be better than
"first-time-from-now"? I find the "now" part confusing. Does it refer to the
moment when the property is set to TRUE? Or rather the moment the first buffer
comes in?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-04-14 08:46:19 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

--- Comment #13 from Georg Lippitsch <***@toolsonair.com> ---
The "now" was chosen based on the function it uses:
g_date_time_new_now_local ();

It is set at the first GST_EVENT_SEGMENT
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-04-14 08:57:10 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778703

--- Comment #14 from Tim-Philipp Müller <***@zen.co.uk> ---
Sure, but are you saying you don't see why it would be confusing? :)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
Loading...