Discussion:
[Bug 743716] New: A bug in 'videomaterial.cpp' and 'openglsurfacepainter.cpp' causes incorrect colors
(too old to reply)
"GStreamer" (bugzilla.gnome.org)
2015-01-29 21:58:05 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=743716
GStreamer | qt-gstreamer | 1.2.0

Summary: A bug in 'videomaterial.cpp' and
'openglsurfacepainter.cpp' causes incorrect colors
Classification: Platform
Product: GStreamer
Version: 1.2.0
OS/Version: Windows
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: qt-gstreamer
AssignedTo: gstreamer-***@lists.freedesktop.org
ReportedBy: duffy-***@msn.com
QAContact: gstreamer-***@lists.freedesktop.org
GNOME version: ---


Colors for the following formats appear to be swapped in the selection for the
matrix corrections in both of theses files:


case GST_VIDEO_COLOR_MATRIX_BT709:
m_colorMatrix *= QMatrix4x4(
1.164, 0.000, 1.793, -0.5727,
1.164, -0.534, -0.213, 0.3007,
1.164, 2.115, 0.000, -1.1302,
0.0, 0.000, 0.000, 1.0000);
break;
case GST_VIDEO_COLOR_MATRIX_BT601:
m_colorMatrix *= QMatrix4x4(
1.164, 0.000, 1.596, -0.8708,
1.164, -0.392, -0.813, 0.5296,
1.164, 2.017, 0.000, -1.081,
0.0, 0.000, 0.000, 1.0000);


Colors are correct when these are swapped like this:

case GST_VIDEO_COLOR_MATRIX_BT601:
m_colorMatrix *= QMatrix4x4(
1.164, 0.000, 1.793, -0.5727,
1.164, -0.534, -0.213, 0.3007,
1.164, 2.115, 0.000, -1.1302,
0.0, 0.000, 0.000, 1.0000);
break;
case GST_VIDEO_COLOR_MATRIX_BT709:
m_colorMatrix *= QMatrix4x4(
1.164, 0.000, 1.596, -0.8708,
1.164, -0.392, -0.813, 0.5296,
1.164, 2.017, 0.000, -1.081,
0.0, 0.000, 0.000, 1.0000);
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2016-06-03 22:16:39 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=743716

Tim-Philipp Müller <***@zen.co.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #1 from Tim-Philipp Müller <***@zen.co.uk> ---
*** Bug 740614 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2016-06-04 06:55:03 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=743716

***@kripserver.net changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@kripserver.net
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2016-09-26 06:09:27 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=743716

Vadim Kuznecov <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #2 from Vadim Kuznecov <***@gmail.com> ---
Not correct matrix (BT709)

http://www.mathworks.com/help/vision/ref/colorspaceconversion.html
Use conversion specified by = Rec. 709 (HDTV)
1.16438356 0 1.79274107
1.16438356 -0.21324861 -0.53290933
1.16438356 2.11240179 0



Correct matrix:
case GST_VIDEO_COLOR_MATRIX_BT709:
m_colorMatrix *= QMatrix4x4(
1.164, 0.000, 1.793, -0.969,
1.164, -0.213, -0.533, 0.300,
1.164, 2.112, 0.000, -1.129,
0.0, 0.000, 0.000, 1.0000);
break;
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-14 18:32:17 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=743716

Martins Mozeiko <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #3 from Martins Mozeiko <***@gmail.com> ---
Created attachment 345749
--> https://bugzilla.gnome.org/attachment.cgi?id=345749&action=edit
fixes wrong values for BT709 color matrix
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-14 18:32:51 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=743716

--- Comment #4 from Martins Mozeiko <***@gmail.com> ---
I can confirm this bug. Changes from Vadim Kuznecov fixes this issue.
I've attached patch that I used to apply on top of 1.2.0.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
Loading...