[Bug 796639] New: souphttpsrc: Protect input stream with lock

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796639

Bug ID: 796639
Summary: souphttpsrc: Protect input stream with lock
Classification: Platform
Product: GStreamer
Version: unspecified
OS: All
Status: NEW
Severity: normal
Priority: Normal
Component: gst-plugins-good
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@bilboed.com
QA Contact: gstreamer-***@lists.freedesktop.org
GNOME version: ---

See commit

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796639

--- Comment #1 from Edward Hervey <***@bilboed.com> ---
Created attachment 372733
--> https://bugzilla.gnome.org/attachment.cgi?id=372733&action=edit
souphttpsrc: Protect input stream with lock

This was the last remaining place where modifying/unreffing the
input stream was not protected by the lock

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796639

--- Comment #2 from Edward Hervey <***@bilboed.com> ---
You could rather easily end up in situations where either the input_stream (and
contained references/objects) were either double-freed or leaked.

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796639

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@coaxion.net
Attachment #372733|none |accepted-commit_now
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796639

Edward Hervey <***@bilboed.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #372733|accepted-commit_now |committed
status| |

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796639

Edward Hervey <***@bilboed.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |***@bilboed.com
Resolution|--- |FIXED

--- Comment #3 from Edward Hervey <***@bilboed.com> ---
Attachment 372733 pushed as 8842d51 - souphttpsrc: Protect input stream with
lock

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796639

Edward Hervey <***@bilboed.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|git master |1.15.1

["GStreamer" (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796639

Tim-Philipp Müller <***@zen.co.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@zen.co.uk
Target Milestone|1.15.1 |1.14.2