Discussion:
[Bug 778782] New: libs: decoder: h264,h265 avoid uninitialized variable
(too old to reply)
"GStreamer" (GNOME Bugzilla)
2017-02-16 17:46:33 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778782

Bug ID: 778782
Summary: libs: decoder: h264,h265 avoid uninitialized variable
Classification: Platform
Product: GStreamer
Version: unspecified
OS: All
Status: NEW
Severity: normal
Priority: Normal
Component: gstreamer-vaapi
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@igalia.com
QA Contact: gstreamer-***@lists.freedesktop.org
CC: ***@gmail.com, ***@igalia.com
GNOME version: ---

Josep Torra mentioned me he is getting some compiler complains regarding
this.

Though I cannot replicate them in my setup, it looks like the code can
be enhanced a little bit there.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-16 17:46:35 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778782

--- Comment #1 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 345981
--> https://bugzilla.gnome.org/attachment.cgi?id=345981&action=edit
libs: decoder: h264,h265 avoid uninitialized variable

Configuring GCC to verify possible usage of uninitialized variables,
shows that found_index might be used without previous assignation.

This patch assigns a initial value to found_index, also avoid a
branching when returning the result value.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-17 00:21:35 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778782

--- Comment #2 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Created attachment 346027
--> https://bugzilla.gnome.org/attachment.cgi?id=346027&action=edit
libs: encoder: h265: bail if nal unit type fails

Bail out if the NAL unit type is not recognized.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-17 00:22:23 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778782

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|libs: decoder: h264,h265 |check for uninitialized
|avoid uninitialized |variables
|variable |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-17 21:48:14 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778782

Josep Torra Valles <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-17 22:01:14 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778782

--- Comment #3 from Josep Torra Valles <***@gmail.com> ---
Both looks good to me and solve all the building issues I was having.

Ship it :) and thanks for looking into them.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-22 04:26:54 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778782

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

--- Comment #4 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Attachment 345981 pushed as d6738f3 - libs: decoder: h264,h265 avoid
uninitialized variable
Attachment 346027 pushed as 7b3a51f - libs: encoder: h265: bail if nal unit
type fails
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-22 04:27:03 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778782

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #346027|none |committed
status| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-22 04:27:07 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778782

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345981|none |committed
status| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-22 04:27:50 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778782

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|git master |1.11.2
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
Loading...