Discussion:
[Bug 778452] New: glsinkbin: leaks sink element
Add Reply
"GStreamer" (GNOME Bugzilla)
2017-02-10 13:44:15 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778452

Bug ID: 778452
Summary: glsinkbin: leaks sink element
Classification: Platform
Product: GStreamer
Version: unspecified
OS: Linux
Status: NEW
Severity: normal
Priority: Normal
Component: gst-plugins-bad
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@gmail.com
QA Contact: gstreamer-***@lists.freedesktop.org
GNOME version: ---

Created attachment 345456
--> https://bugzilla.gnome.org/attachment.cgi?id=345456&action=edit
Proposed patch

GstGLSinkBin adds a reference to the sink element in set_property() but never
releases it in dispose or finalize methods.

The proposed patch does not add that reference and relies in the indirect
reference added by gst_bin_add() instead (just like its already doing with
upload convert and balance elements)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-14 10:18:58 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778452

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |***@coaxion.net
Resolution|--- |FIXED

--- Comment #1 from Sebastian Dröge (slomo) <***@coaxion.net> ---
commit ef739e726fb52305245f8bbf7d26f8e2ae0f71e2
Author: Juan Pablo Ugarte <***@gmail.com>
Date: Fri Feb 10 10:29:49 2017 -0300

GstGLSinkBin: fixed sink property leak

No need to keep an extra reference to sink since an indirect one is added
by gst_bin_add()

https://bugzilla.gnome.org/show_bug.cgi?id=778452
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-14 10:19:02 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778452

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345456|none |committed
status| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-14 10:19:41 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778452

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|git master |1.11.2
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-19 10:54:29 UTC
Reply
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778452

Sebastian Dröge (slomo) <***@coaxion.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|1.11.2 |1.10.4
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
Loading...