Discussion:
[Bug 778749] New: Using vaapih265enc without h265parse causes assert
(too old to reply)
"GStreamer" (GNOME Bugzilla)
2017-02-16 09:03:14 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

Bug ID: 778749
Summary: Using vaapih265enc without h265parse causes assert
Classification: Platform
Product: GStreamer
Version: 1.11.1
OS: Linux
Status: NEW
Severity: normal
Priority: Normal
Component: gstreamer-vaapi
Assignee: gstreamer-***@lists.freedesktop.org
Reporter: ***@intel.com
QA Contact: gstreamer-***@lists.freedesktop.org
CC: ***@gmail.com, ***@igalia.com
GNOME version: ---

When executing the example command from here:

https://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer-vaapi-plugins/html/gstreamer-vaapi-plugins-vaapih265enc.html

gst-launch-1.0 -ev videotestsrc num-buffers=60 ! vaapih265enc ! matroskamux !
filesink location=test.mkv

This will cause an assert in the “gst-libs/gst/vaapi/gstvaapiencoder_h265.c” in
the function “GstVaapiEncoderStatus”. There are a couple of asserts added and
the first one always triggers since the bitsize count at that place is 154 and
all the nbits inputs to the WRITE_UINT32 function are hardcoded values.

When adding a h265parse to the command, the encoding succeeds.

gst-launch-1.0 -e videotestsrc num-buffers=60 ! vaapih265enc ! h265parse !
matroskamux ! filesink location=test.mkv
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-16 21:00:33 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

--- Comment #1 from sreerenj <***@gmail.com> ---
https://bugzilla.gnome.org/show_bug.cgi?id=778750#c1
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-02-17 06:03:39 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

Hyunjun Ko <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@igalia.com
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-03-13 07:23:56 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

--- Comment #2 from Hyunjun Ko <***@igalia.com> ---
Created attachment 347802
--> https://bugzilla.gnome.org/attachment.cgi?id=347802&action=edit
libs: encoder: h265: fix reserved length of bits

Fix reserved length of bits for bit_depth_luma_minus8 and
bit_depth_chroma_minus8


-----

Reference:
http://fushizen.eu/random/W13478_1_pt15-3rd_FDIS_clean.pdf
http://labs.divx.com/book/export/html/127907
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-03-13 07:24:27 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

--- Comment #3 from Hyunjun Ko <***@igalia.com> ---
@Soren Friis, could you confirm this patch?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-03-13 08:03:03 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

--- Comment #4 from Soren Friis <***@intel.com> ---
Thanks. This fixes the assert.

I guess you could change the 0x3f part to 0x1f as well, since only 5 bits are
being written. Having 0x3f there probably won't break anything though.

Could you get the example on the wiki page updated? Sreerenj told me that you
are actually not supposed to ever run the H.265 encoding without the h265parse
element, which mean that the example is now misleading.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-03-13 08:19:56 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

--- Comment #5 from Hyunjun Ko <***@igalia.com> ---
(In reply to Soren Friis from comment #4)
Post by "GStreamer" (GNOME Bugzilla)
Thanks. This fixes the assert.
I guess you could change the 0x3f part to 0x1f as well, since only 5 bits
are being written. Having 0x3f there probably won't break anything though.
Ah, you're right.
Post by "GStreamer" (GNOME Bugzilla)
Could you get the example on the wiki page updated? Sreerenj told me that
you are actually not supposed to ever run the H.265 encoding without the
h265parse element, which mean that the example is now misleading.
Okay. Apparently, using h264parse is recommendable.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-03-13 08:22:16 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

Hyunjun Ko <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #347802|0 |1
is obsolete| |

--- Comment #6 from Hyunjun Ko <***@igalia.com> ---
Created attachment 347807
--> https://bugzilla.gnome.org/attachment.cgi?id=347807&action=edit
libs: encoder: h265: fix reserved length of bits

Fix reserved length of bits for bit_depth_luma_minus8 and
bit_depth_chroma_minus8
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-03-13 08:31:35 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

--- Comment #7 from Hyunjun Ko <***@igalia.com> ---
Created attachment 347808
--> https://bugzilla.gnome.org/attachment.cgi?id=347808&action=edit
docs: h264/h265: put parser to the example pipeline
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-03-14 16:09:12 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #347808|none |accepted-commit_now
status| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-03-14 16:09:28 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #347807|none |accepted-commit_now
status| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-03-14 16:20:50 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

--- Comment #8 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
Attachment 347807 pushed as 7f38b3b - libs: encoder: h265: fix reserved length
of bits
Attachment 347808 pushed as e65d916 - docs: h264/h265: put parser to the
example pipeline
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-03-14 16:20:54 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #347808|accepted-commit_now |committed
status| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-03-14 16:20:58 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #347807|accepted-commit_now |committed
status| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-03-14 16:21:29 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|git master |1.11.3
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-03-14 16:26:19 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

--- Comment #9 from Víctor Manuel Jáquez Leal <***@igalia.com> ---
branch 1.10

* 01bf6574 docs: h264/h265: put parser to the example pipeline
* f266250e libs: encoder: h265: fix reserved length of bits
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
"GStreamer" (GNOME Bugzilla)
2017-03-14 16:26:30 UTC
Permalink
Raw Message
https://bugzilla.gnome.org/show_bug.cgi?id=778749

Víctor Manuel Jáquez Leal <***@igalia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|1.11.3 |1.10.5
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
Loading...