[Bug 741321] New: Problem using opusparse between decoder and encoder

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741321
GStreamer | gst-plugins-bad | 1.4.4

Summary: Problem using opusparse between decoder and encoder
Classification: Platform
Product: GStreamer
Version: 1.4.4
OS/Version: Linux
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: gst-plugins-bad
AssignedTo: gstreamer-***@lists.freedesktop.org
ReportedBy: ***@gmail.com
QAContact: gstreamer-***@lists.freedesktop.org
GNOME version: ---


Hello,

I'm trying to use opus as audio codec but I'm having troubles with the opus
parser. If I use opusparse to configure the caps of the opus depayloader or the
opus decoder I get an opus decoder error -4 (OPUS_INVALID_PACKET), but if I set
the caps manually everything works ok.

The error is very easy to reproduce. This pipeline works ok:
gst-launch-1.0 audiotestsrc ! opusenc ! opusdec ! autoaudiosink

But this one throws the error -4:
gst-launch-1.0 audiotestsrc ! opusenc ! opusparse ! opusdec ! autoaudiosink

I have tested many pipelines using parsers between decoder and encoder and all
work ok:

gst-launch-1.0 audiotestsrc ! vorbisenc ! vorbisparse ! decodebin !
autoaudiosink
gst-launch-1.0 videotestsrc ! x264enc ! h264parse ! decodebin ! autovideosink

I think there is a problem in the opusparse element, but I can't find it.

Thanks in advance.
Regards.

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741321
GStreamer | gst-plugins-bad | 1.4.4

Vincent Penquerc'h <vincent.penquerch> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEEDINFO
CC| |***@collabora
| |.co.uk

--- Comment #1 from Vincent Penquerc'h <***@collabora.co.uk> 2014-12-15 09:55:15 UTC ---
Seems to work fine with recent-ish master, which should be pretty close to
1.4.4, though there was no relevant change to opusparse for a while.

$ gst-launch-1.0 audiotestsrc ! opusenc ! opusparse ! opusdec ! autoaudiosink
Setting pipeline to PAUSED ...
Pipeline is PREROLLING ...
Redistribute latency...
Pipeline is PREROLLED ...
Setting pipeline to PLAYING ...
New clock: GstPulseSinkClock
^Chandling interrupt.
Interrupt: Stopping pipeline ...
Execution ended after 0:00:05.384966283
Setting pipeline to PAUSED ...
Setting pipeline to READY ...
Setting pipeline to NULL ...
Freeing pipeline ...

Maybe a GST_DEBUG=2,opus*:9 might help shed some light.

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741321
GStreamer | gst-plugins-bad | 1.4.4

Miguel París Díaz <mparisdiaz> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741321
GStreamer | gst-plugins-bad | 1.4.4

--- Comment #2 from David Fernandez <***@gmail.com> 2014-12-15 10:11:35 UTC ---
Created an attachment (id=292745)
--> (https://bugzilla.gnome.org/attachment.cgi?id=292745)
execution log

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741321
GStreamer | gst-plugins-bad | 1.4.4

--- Comment #3 from David Fernandez <***@gmail.com> 2014-12-15 10:11:57 UTC ---
(From update of attachment 292745)
Hi Vincent,

Thanks for your response. I can't update my gstreamer version to master, but as
you said, it not seems to be relevant changes. I have attached the log of the
execution. I hope it will be relevant for you.

Regards.
David.

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741321
GStreamer | gst-plugins-bad | 1.4.4

Vincent Penquerc'h <vincent.penquerch> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
Ever Confirmed|0 |1

--- Comment #4 from Vincent Penquerc'h <***@collabora.co.uk> 2014-12-15 12:04:13 UTC ---
I now get the same error after updating my copy of libopus.

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741321
GStreamer | gst-plugins-bad | 1.4.4

Vincent Penquerc'h <vincent.penquerch> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
Target Milestone|HEAD |1.5.1

--- Comment #5 from Vincent Penquerc'h <***@collabora.co.uk> 2014-12-15 15:26:12 UTC ---
I have no idea why it was working originally. I had an old copy of libopus, but
trying those also failed. In any case, I found the bug in opusparse:


commit 79b56ebcc9511a50d9fe9fbb93b48d5c2170bad8
Author: Vincent Penquerc'h <***@collabora.co.uk>
Date: Mon Dec 15 15:21:50 2014 +0000

opusparse: fix frame size determination

https://bugzilla.gnome.org/show_bug.cgi?id=741321

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741321
GStreamer | gst-plugins-bad | 1.4.4

--- Comment #6 from David Fernandez <***@gmail.com> 2014-12-15 15:59:20 UTC ---
The patch works fine for me.

Thank you very much.

Regards.

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741321
GStreamer | gst-plugins-bad | 1.4.4

Tim-Philipp Müller <t.i.m> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@zen.co.uk
Target Milestone|1.5.1 |1.4.5
Summary|Problem using opusparse |opusparse: fix header
|between decoder and encoder |parsing esp. of encoded
| |output of newer versions of
| |libopus

--- Comment #7 from Tim-Philipp Müller <***@zen.co.uk> 2014-12-15 17:59:11 UTC ---
Cherry-picked into 1.4 branch.

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741321
GStreamer | gst-plugins-bad | 1.4.4

Vincent Penquerc'h <vincent.penquerch> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|opusparse: fix header |opusparse: fix header
|parsing esp. of encoded |parsing esp. of encoded
|output of newer versions of |output of libopus
|libopus |

["GStreamer" (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741321
GStreamer | gst-plugins-bad | 1.4.4

--- Comment #8 from Vincent Penquerc'h <***@collabora.co.uk> 2014-12-15 19:06:10 UTC ---
Just resetting the title as it happens also with old opus too. I have no idea
why it worked with the version I had originally, but when I tried to bisect in
libopus, it continued to fail till before the version I originally had. So it's
just a bug in opusparse, independent of the libopus version.